This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013年10月30日 09:55 by christian.heimes, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| ssl_asn1obj.patch | christian.heimes, 2013年10月30日 09:55 | review | ||
| ssl_asn1obj2.patch | christian.heimes, 2013年11月01日 17:04 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg201724 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2013年10月30日 09:55 | |
For #17134 I need a decent way to map OIDs to human readable strings and vice versa. OpenSSL has a couple of method for the task, e.g. http://www.openssl.org/docs/crypto/OBJ_nid2obj.html The patch implements three ways to lookup NID, SN, LN and OID: by OpenSSL's internal numeric id (NID), by OID or by name: >>> ssl.txt2obj("MD5", name=True) ASN1Object(nid=4, shortname='MD5', longname='md5', oid='1.2.840.113549.2.5') >>> ssl.txt2obj("clientAuth", name=True) ASN1Object(nid=130, shortname='clientAuth', longname='TLS Web Client Authentication', oid='1.3.6.1.5.5.7.3.2') >>> ssl.txt2obj("1.3.6.1.5.5.7.3.1") ASN1Object(nid=129, shortname='serverAuth', longname='TLS Web Server Authentication', oid='1.3.6.1.5.5.7.3.1') |
|||
| msg201916 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2013年11月01日 17:04 | |
Thanks for the feed back! The new patch implements a class with two additional class methods. The low level functions are no longer part of the public API. |
|||
| msg203151 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2013年11月17日 13:49 | |
Does anybody want to do a review of the patch? |
|||
| msg203154 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2013年11月17日 13:59 | |
If it's for #17134, couldn't it remain a private API? I'm rather uncomfortable about exposing such things unless we make the ssl module a full-fledged toolbox to handle X509 certificates (and perhaps think a bit more about the APIs). Are there any common use cases? |
|||
| msg203199 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2013年11月17日 16:47 | |
OK, let's keep it as private API for now and maybe make it public in 3.5. I'm going to rename ASN1Object to _ASN1Object, remove the docs and adjust the tests. Agreed? |
|||
| msg203200 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2013年11月17日 16:51 | |
> OK, let's keep it as private API for now and maybe make it public in > 3.5. I'm going to rename ASN1Object to _ASN1Object, remove the docs > and adjust the tests. Agreed? Yup. |
|||
| msg203208 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年11月17日 19:04 | |
New changeset f43f65038e2a by Christian Heimes in branch 'default': Issue #19448: Add private API to SSL module to lookup ASN.1 objects by OID, NID, short name and long name. http://hg.python.org/cpython/rev/f43f65038e2a |
|||
| msg203209 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2013年11月17日 19:10 | |
Thanks! |
|||
| msg203784 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年11月22日 15:21 | |
New changeset 7d914d4b05fe by Christian Heimes in branch 'default': Issue #19448: report name / NID in exception message of ASN1Object http://hg.python.org/cpython/rev/7d914d4b05fe |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:52 | admin | set | github: 63647 |
| 2013年11月22日 15:21:03 | python-dev | set | messages: + msg203784 |
| 2013年11月17日 19:10:22 | christian.heimes | set | status: open -> closed resolution: fixed messages: + msg203209 stage: patch review -> resolved |
| 2013年11月17日 19:04:54 | python-dev | set | nosy:
+ python-dev messages: + msg203208 |
| 2013年11月17日 16:55:53 | christian.heimes | set | assignee: christian.heimes |
| 2013年11月17日 16:51:42 | pitrou | set | messages: + msg203200 |
| 2013年11月17日 16:47:54 | christian.heimes | set | messages: + msg203199 |
| 2013年11月17日 13:59:28 | pitrou | set | nosy:
+ dstufft messages: + msg203154 |
| 2013年11月17日 13:49:54 | christian.heimes | set | messages: + msg203151 |
| 2013年11月01日 17:04:16 | christian.heimes | set | files:
+ ssl_asn1obj2.patch messages: + msg201916 |
| 2013年10月30日 09:55:08 | christian.heimes | create | |