homepage

Here is a (exhaustive?) list of tests which deliberately crash the interpreter:
- test_daemon_threads_fatal_error() in test_threading
- several fatal error tests in test_faulthandler
- test_recursionlimit_fatalerror() in test_sys
- test_no_FatalError_infinite_loop() in test_capi
They should reuse the new SuppressCoreFiles facility from test.support.

Great! Thanks for putting together a list. I've incorporated SuppressCoreFiles into these tests and have used the test suite without any errors. Again, I'm testing these on Ubuntu.

Ok, I've left a comment on the review tool above. You can click on the "review" link if you haven't received an e-mail.

Oops! That was careless. Fixed.

Perhaps it would be best to either combine SuppressCoreFiles and suppress_crash_popup, or provide a new construct that does so since both are used in almost every place one is used. Also, test_daemon_threads_fatal_error in test_threading should be using suppress_crash_popup, but isn't currently, which I believe falls under the scope of this issue.

> Perhaps it would be best to either combine SuppressCoreFiles
> and suppress_crash_popup
Yes, these two tools must be merged into one unique portable tool. Example of names:
 * ignore_fatal_errors()
 * dont_report_crashes()
 * ignore_crashes()
Doc: "On Windows, don't display the Windows Error Reporting dialog. On UNIX, disable the creation of coredump file."

test.support.SuppressCoreFiles was added by #18623.
I implemented a similar tool in my tracemalloc fork:
http://hg.python.org/features/tracemalloc/rev/b91450e51388 

Here's a patch that combines Valerie's patch with a merged suppress_crash_popup and SuppressCoreFiles called SuppressCrashReport. 
Tests ok on Windows; I haven't been able to test on Unix yet.

Thanks! The patch works fine here under Linux, too (though I haven't tried to figure out if it really prevented core files from being generated).

New changeset 1cbd3d9f7d61 by Antoine Pitrou in branch 'default':
Issue #18948: improve SuppressCoreFiles to include Windows crash popup suppression, and use it in more tests.
http://hg.python.org/cpython/rev/1cbd3d9f7d61 

Patch committed. Thanks to both of you!