homepage

Attached patch fixes different compiler warnings on Windows x64 in the zlib module. The module raises OverflowError if some values are longer than INT_MAX, but not all parameters are checked.

Related issue: #9566.

The changeset 931e1bc090f6 fixes warnings in adler32 and crc32.

@Serhiy: Oh, thanks for your review. My patch was far from being perfect, a review was necessary! (I hesitated to commit it directly.)
Here is a new patch using unsigned int is most places, parsing arguments with "I" format, and explicit cast to (size_t) to not compare unsigned with signed.

"Here is a new patch using unsigned int is most places, parsing
arguments with "I" format, and explicit cast to (size_t) to not
compare unsigned with signed."
Oh oh, it's still wrong. The "I" parser format does not check for
integer overflow. _PyBytes_Resize() also uses "Py_DECREF(retVal);
retVal = NULL;" on failure, instead of Py_CLEAR(retVal), whereas
_PyBytes_Resize(&retVal, ...) sets retVal to NULL...

Ping myself.

> The "I" parser format does not check for integer overflow.
The "O" format can be used with _PyLong_AsInt() instead.

zlib_64bit-3.patch: updated patch which fixes also the PyArg_ParseTuple() convert for C int and C unsigned int.

zlib_64bit-4.patch:
* fix usage of argument clinic, add a uint_converter
* fix zlib_Decompress_decompress(): use an unsigned int, not an int (remove int_converter())
* fix two bugs and unit tests

LGTM.

New changeset f947fe289db8 by Victor Stinner in branch 'default':
Close #18294: Fix the zlib module to make it 64-bit safe
http://hg.python.org/cpython/rev/f947fe289db8 

> LGTM.
I changed the "uint" parser to raise a ValueError instead of an OverflowError, so the unit test doesn't need to be adapted.
Thanks again Serhiy for your review :)
I doesn't want to backport the fix to Python 2.7 or 3.3, it's more intrusive than what I expected. I opened the issue to fix compiler warnings, it's not like an user complained about a crash.

New changeset 0cca6c5513d2 by Victor Stinner in branch 'default':
Issue #18294: Fix uint_converter() in zlibmodule.c, fix the "> UINT_MAX" check
http://hg.python.org/cpython/rev/0cca6c5513d2