This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013年06月04日 00:15 by terry.reedy, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| config_name.diff | terry.reedy, 2013年06月04日 00:15 | 3.3 and 3.4 | review | |
| config_name27.diff | terry.reedy, 2013年06月04日 00:15 | |||
| Messages (2) | |||
|---|---|---|---|
| msg190572 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2013年06月04日 00:15 | |
The patch to configSectionNameDialog.py fixes the human test (adds required arg) so it runs, adds instructions to the test, fixes a bug in name_ok, removes redundant code, adds needed spaces, de-camelcases internal names, and changes the master for the two StringVars so they can be collected [sys:1: ResourceWarning: gc: 2 uncollectable objects at shutdown [<tkinter.StringVar object at 0x02C597E0>, <tkinter.StringVar ...]]. (I plan to open an issue about this.) The new mock_tk.py adds generic mocks for tkinter String/Int/BooleanVars and tkinter.messagebox and its 8 functions. The new test_name_dialog.py uses these to unittest the non-gui parts of the dialog. The backport to 2.7 required changes to the tkinter imports and print in configSectionNameDialog.py and in test_config_name.py, addition of '.im_func' to the names of methods/functions being added to the dummy class. Both unittests and human tests run on all three branches. I believe the patches are ready to commit. |
|||
| msg190686 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年06月05日 18:41 | |
New changeset db4ecaf852e3 by Terry Jan Reedy in branch '3.3': Issue18130: Test class idlelib.configSectionNameDialog.GetCfgSectionNameDialog. http://hg.python.org/cpython/rev/db4ecaf852e3 New changeset 31a67a0194ec by Terry Jan Reedy in branch '2.7': Issue18130: Test class idlelib.configSectionNameDialog.GetCfgSectionNameDialog. http://hg.python.org/cpython/rev/31a67a0194ec New changeset 382f4718e765 by Terry Jan Reedy in branch '3.3': Issue 18130: delete extra spaces http://hg.python.org/cpython/rev/382f4718e765 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:46 | admin | set | github: 62330 |
| 2013年06月05日 22:57:32 | terry.reedy | set | status: open -> closed resolution: fixed stage: commit review -> resolved |
| 2013年06月05日 18:41:10 | python-dev | set | nosy:
+ python-dev messages: + msg190686 |
| 2013年06月04日 00:33:13 | terry.reedy | link | issue18104 dependencies |
| 2013年06月04日 00:15:43 | terry.reedy | set | files: + config_name27.diff |
| 2013年06月04日 00:15:19 | terry.reedy | create | |