This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013年03月19日 20:00 by Thomas Fenzl, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| getpass_tests.diff | Thomas Fenzl, 2013年03月19日 22:20 | patch for the new test file and default-initialization of passwd | review | |
| getpass_tests-2.diff | Thomas Fenzl, 2013年03月19日 22:31 | includes removing getpass from test_sundry.py | review | |
| getpass_tests-3.diff | Thomas Fenzl, 2013年03月20日 07:10 | changed style after review, added a test | review | |
| getpass_tests.patch | r.david.murray, 2013年04月03日 01:13 | Further slight cleanup. | review | |
| Messages (10) | |||
|---|---|---|---|
| msg184691 - (view) | Author: Thomas Fenzl (Thomas Fenzl) * | Date: 2013年03月19日 22:20 | |
This is a patch adding tests for the platform independend and unix specific parts of getpass. I also default initialized passwd in unix_getpass. Otherwise almost all tests would require full mocking of termios settings and such. |
|||
| msg184710 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2013年03月19日 23:57 | |
I've added some review comments, mostly style issues. |
|||
| msg185871 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2013年04月03日 01:13 | |
Thomas, did you submit a contributor agreement at PyCon (or after)? If so I need to go bug someone to get the tracker updated. I'm attaching a slightly modified version of your patch, cleaning up the output that was showing up on stdout and using assertWarns rather than monkey patching the warnings module. Oh, and making the with-clause indentation PEP8 compliant...I wasn't very clear in my review comment about how that was supposed to look. |
|||
| msg185938 - (view) | Author: Thomas Fenzl (Thomas Fenzl) * | Date: 2013年04月03日 17:05 | |
I signed the contributor agreement during pycon, with the pdf sent to me on March 19th, 15:25 PDT |
|||
| msg186279 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年04月08日 05:49 | |
New changeset 4059ef685754 by R David Murray in branch 'default': #17484: add tests for getpass. http://hg.python.org/cpython/rev/4059ef685754 |
|||
| msg186284 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2013年04月08日 10:02 | |
Did you forget to add test_getpass.py? |
|||
| msg186294 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2013年04月08日 12:46 | |
Indeed I did. That's what I get for staging it one day and committing it the next...I forgot I hadn't done the add command. |
|||
| msg186295 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年04月08日 12:48 | |
New changeset 113ff45c3f11 by R David Murray in branch 'default': #17484: Actually add the getpass tests this time. http://hg.python.org/cpython/rev/113ff45c3f11 |
|||
| msg186296 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2013年04月08日 12:49 | |
Thanks, Thomas. |
|||
| msg207000 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年12月27日 16:48 | |
New changeset 100f632d4306 by R David Murray in branch '3.3': #18116: backport fix to 3.3 since real-world failure mode demonstrated. http://hg.python.org/cpython/rev/100f632d4306 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:43 | admin | set | github: 61686 |
| 2013年12月27日 16:48:23 | python-dev | set | messages: + msg207000 |
| 2013年04月08日 12:49:14 | r.david.murray | set | status: open -> closed resolution: fixed messages: + msg186296 stage: resolved |
| 2013年04月08日 12:48:19 | python-dev | set | messages: + msg186295 |
| 2013年04月08日 12:46:50 | r.david.murray | set | messages: + msg186294 |
| 2013年04月08日 10:02:38 | pitrou | set | nosy:
+ pitrou messages: + msg186284 |
| 2013年04月08日 05:49:06 | python-dev | set | nosy:
+ python-dev messages: + msg186279 |
| 2013年04月03日 17:05:27 | Thomas Fenzl | set | messages: + msg185938 |
| 2013年04月03日 01:13:03 | r.david.murray | set | files:
+ getpass_tests.patch messages: + msg185871 |
| 2013年03月20日 07:10:06 | Thomas Fenzl | set | files: + getpass_tests-3.diff |
| 2013年03月19日 23:57:05 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg184710 |
| 2013年03月19日 22:31:11 | Thomas Fenzl | set | files: + getpass_tests-2.diff |
| 2013年03月19日 22:20:01 | Thomas Fenzl | set | files:
+ getpass_tests.diff keywords: + patch messages: + msg184691 |
| 2013年03月19日 20:00:39 | Thomas Fenzl | create | |