homepage

read_until() takes a value for timeout in seconds, but passes it to poll(), which takes a value in milliseconds.

Updated patch to fix expect() as well.

Thanks for the bug report, Reuben. I verified that this is indeed a bug and should be fixed in all versions. Thanks for the patch too, would you like to enhance it with tests? GeneralTests in test_telnetlib.py support timeout and you could that exercise timeout value in secs.

this bug was likely introduced when i applied the telnetlib patches to use poll to not hit the select fd limit. doh. nice catch!

@gps: looks like it is. For changeset: 78129:de229dde486b for Issue #14635 

Sure, no problem. I'll upload the completed patch once I've got it working.

OK, I've implemented tests for read_until() and expect() using both poll and select. I ended up rewriting _read_until_with_select() to look more like the poll equivalent in the process, which should hopefully make it more maintainable.

0 and None must be different.

The patch is not compatible with 3.4. Does this bug exist in 3.4?

> The patch is not compatible with 3.4. Does this bug exist in 3.4?
No, selectors all expect a timeout in seconds, so this should be fixed in 3.4.

Last patch is corrupted and outdated. Here is updated and fixed version. I have not examined it closely.

Review comments added. I don't really see why the fix should not be as trivial as:
diff -r ca9bca7aecda Lib/telnetlib.py
--- a/Lib/telnetlib.py Tue Dec 10 16:06:46 2013 -0600
+++ b/Lib/telnetlib.py Tue Dec 10 18:08:37 2013 -0800
@@ -312,7 +312,9 @@
 poller.register(self, poll_in_or_priority_flags)
 while i < 0 and not self.eof:
 try:
- ready = poller.poll(call_timeout)
+ # Poll takes its timeout in milliseconds.
+ ready = poller.poll(None if timeout is None
+ else 1000 * call_timeout)
 except select.error as e:
 if e.errno == errno.EINTR:
 if timeout is not None:
@@ -682,7 +684,8 @@
 poller.register(self, poll_in_or_priority_flags)
 while not m and not self.eof:
 try:
- ready = poller.poll(call_timeout)
+ ready = poller.poll(None if timeout is None
+ else 1000 * call_timeout)
 except select.error as e:
 if e.errno == errno.EINTR:
 if timeout is not None:

New changeset d61e8050b7d7 by Gregory P. Smith in branch '2.7':
Fixes Issue #17200: telnetlib's read_until and expect timeout was broken by the
http://hg.python.org/cpython/rev/d61e8050b7d7
New changeset 46186736e91c by Gregory P. Smith in branch '3.3':
Fixes Issue #17200: telnetlib's read_until and expect timeout was broken by the
http://hg.python.org/cpython/rev/46186736e91c 

> Review comments added.
Only original author can answer your questions.
> I don't really see why the fix should not be as trivial as:
Yes, these are simple and obvious, and only changes which I understand.

anyways, i went with just the simple fix and no specific test for this issue as the tests were painful and questionable reliability.
i appreciate the other refactoring suggestion within the code but for 2.7 and 3.3 bugfixes where no significant changes are ever likely within telnetlib.py they didn't seem warranted. 3.4's code is cleaner thanks to the new selector stuff.