This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2007年12月14日 19:45 by rhettinger, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Messages (11) | |||
|---|---|---|---|
| msg58634 - (view) | Author: Raymond Hettinger (rhettinger) * (Python committer) | Date: 2007年12月14日 19:45 | |
It would be helpful to have the name provide a cue that a macro is being used. |
|||
| msg58635 - (view) | Author: Guido van Rossum (gvanrossum) * (Python committer) | Date: 2007年12月14日 19:54 | |
Agreed. |
|||
| msg58636 - (view) | Author: Martin v. Löwis (loewis) * (Python committer) | Date: 2007年12月14日 20:13 | |
I assume that applies to Py_Refcnt and Py_Type as well? |
|||
| msg58637 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2007年12月14日 21:05 | |
I think it would be easier to merge from trunk to py3k before the change and skip the revision in the next merge. The rename can be done with a simple find | xargs sed -i. A merge might be more painful. |
|||
| msg58734 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2007年12月18日 09:40 | |
I tried a simple find | xargs sed replace and it worked well. find -name '*.c' -or -name '*.h' -or -name '*.rst' | xargs sed -i s/Py_Size\(/Py_SIZE\(/g |
|||
| msg58793 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2007年12月19日 06:47 | |
I've renamed the three macros and added the old names for b/w compatibility. |
|||
| msg58797 - (view) | Author: Martin v. Löwis (loewis) * (Python committer) | Date: 2007年12月19日 08:02 | |
Why the compatibility? |
|||
| msg58798 - (view) | Author: Martin v. Löwis (loewis) * (Python committer) | Date: 2007年12月19日 08:06 | |
FWIW, should PyUnicode_Check, PyTuple_Check etc. also change to PyUnicode_CHECK, PyTuple_CHECK etc because they are macros? |
|||
| msg58799 - (view) | Author: Martin v. Löwis (loewis) * (Python committer) | Date: 2007年12月19日 08:08 | |
I've fixed PEP 3123 to update the spelling. |
|||
| msg58818 - (view) | Author: Guido van Rossum (gvanrossum) * (Python committer) | Date: 2007年12月19日 18:37 | |
> FWIW, should PyUnicode_Check, PyTuple_Check etc. also change to > PyUnicode_CHECK, PyTuple_CHECK etc because they are macros? While this would technically be the right thing to do, those macros have had a long and productive life before 2.6 so I'd rather be compatible. IOW no. |
|||
| msg258838 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年01月22日 21:17 | |
New changeset 63183596db79 by Gregory P. Smith in branch '2.7': Per issue21949 and issue1629: Document the Py_SIZE, Py_TYPE, Py_REFCNT macros. https://hg.python.org/cpython/rev/63183596db79 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:29 | admin | set | github: 45970 |
| 2016年01月22日 21:17:59 | python-dev | set | nosy:
+ python-dev messages: + msg258838 |
| 2007年12月19日 18:37:04 | gvanrossum | set | messages: + msg58818 |
| 2007年12月19日 08:08:25 | loewis | set | messages: + msg58799 |
| 2007年12月19日 08:06:50 | loewis | set | messages: + msg58798 |
| 2007年12月19日 08:02:35 | loewis | set | messages: + msg58797 |
| 2007年12月19日 06:48:01 | christian.heimes | set | status: open -> closed resolution: accepted -> fixed messages: + msg58793 |
| 2007年12月18日 19:14:56 | gvanrossum | set | resolution: accepted |
| 2007年12月18日 09:40:43 | christian.heimes | set | messages: + msg58734 |
| 2007年12月14日 21:05:45 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg58637 |
| 2007年12月14日 20:13:27 | loewis | set | messages: + msg58636 |
| 2007年12月14日 19:54:30 | gvanrossum | set | nosy:
+ gvanrossum messages: + msg58635 |
| 2007年12月14日 19:45:41 | rhettinger | create | |