homepage

This issue is to fix invocations of URLError so that "reasons" are not passed in for the "filename" argument of the URLError constructor.
Ezio found and described this issue when commenting on issue 10836:
 http://bugs.python.org/issue10836#msg172988
In more detail: URLError accepts "reason" and "filename" arguments:
http://hg.python.org/cpython/file/74b95194ba86/Lib/urllib/error.py#l23
However, in several places in Lib/urllib, URLError is invoked with a "reason" passed in for the filename. For example:
 raise URLError('local file error', 'not on local host')
This issue could be addressed for this example by changing the above to:
 raise URLError('local file error: not on local host')
This dovetails with issue #16247, which is to start passing the actual filename in for some calls to URLError (and perhaps to adjust URLError's __str__, etc).

> raise URLError('local file error: not on local host')
I should also point out that URLError invocations with formats like the above already do occur in Lib/urllib/request.py. For example:
 raise URLError('ftp error: no host given')
 exc = URLError('ftp error: %s' % msg)
 raise URLError("http protocol error: bad status line")

For future reference, this affects 3.2 onwards. It probably makes sense to address this in the same branches in which we plan to address issue 16247 (currently set to 3.3 onwards).

This patch fixed these URLError wrong invocation issue and adds some tests for testing those it. 
I noticed that some of these were in the dead-end of the code, like checking if url is not a str (it is always, unwrap makes it a str if otherwise). Those will have to be cleaned and I shall do it next.

New changeset 8fb438e7f738 by Senthil Kumaran in branch 'default':
Issue #16250: Fix the invocations of URLError which had misplaced filename attribute for exception
http://hg.python.org/cpython/rev/8fb438e7f738 

This is fixed in 3.4. I shall backport to other branches.

This broke the Windows 7 buildbot:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/850 

The change in 49de26395d1a addresses the buildbot failure. I have given a run again.

The change I had made for fixing the windows buildbot had not fixed it. I am skipped (1f92315d9568) the test on windows, investigating the reason for windows behavior and I shall remove the skiptest on windows after fix.

New changeset 5e71f2712076 by Senthil Kumaran in branch '3.2':
Issue #16250: Fix URLError invocation with proper args.
http://hg.python.org/cpython/rev/5e71f2712076
New changeset 30547e2cd04d by Senthil Kumaran in branch '3.3':
Issue #16250: Fix URLError invocation with proper args
http://hg.python.org/cpython/rev/30547e2cd04d 

New changeset 3fb84c1da8c5 by Senthil Kumaran in branch '2.7':
Add some tests in 2.7 for Issue #16250
http://hg.python.org/cpython/rev/3fb84c1da8c5 

This is fixed in all versions now.