This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012年05月16日 22:17 by ssm, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| plistlib_empty_objects.patch | ssm, 2012年05月16日 22:17 | Patch to plistlib | review | |
| plistlib_empty_element_test.patch | ssm, 2012年05月27日 17:40 | Regression test | review | |
| Messages (9) | |||
|---|---|---|---|
| msg160934 - (view) | Author: Sidney San Martín (ssm) * | Date: 2012年05月16日 22:17 | |
plistlib’s output is currently byte-for-byte identical to Apple’s, except arrays and dictionaries are stored with self-closing tags (e.g. '<array/>') and plistlib outputs empty tags with a newline (e.g. '<array>\n</array>'). This tiny patch makes its output for empty arrays and dictionaries consistent with the OS’s. |
|||
| msg161562 - (view) | Author: Hynek Schlawack (hynek) * (Python committer) | Date: 2012年05月25日 10:24 | |
Sidney, would you mind adding a regression test for both cases? Ned, Ronald what's your take on this? |
|||
| msg161563 - (view) | Author: Ronald Oussoren (ronaldoussoren) * (Python committer) | Date: 2012年05月25日 10:29 | |
The patch looks fine, but as you noticed there should be a test case for this. I'm -1 w.r.t. applying this to 3.2 or 2.7, it is a functional change that isn't a bug (Apple's libraries will happily read empty arrays that are written as <array></array>). |
|||
| msg161564 - (view) | Author: Ronald Oussoren (ronaldoussoren) * (Python committer) | Date: 2012年05月25日 10:33 | |
Sidney: Would you be willing to sign the contributor agreement? The following page contains more information on the agreement: http://www.python.org/psf/contrib/ |
|||
| msg161713 - (view) | Author: Sidney San Martín (ssm) * | Date: 2012年05月27日 17:40 | |
Hynek: Here you go! Ronald: Emailed it in on Friday. |
|||
| msg161859 - (view) | Author: Hynek Schlawack (hynek) * (Python committer) | Date: 2012年05月29日 07:59 | |
The patch LGTM, but Pam seemed to have problems to find your account (http://mail.python.org/pipermail/python-committers/2012-May/002037.html) – did you get the reply and followed up on that? |
|||
| msg161863 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2012年05月29日 10:08 | |
New changeset 9e64084f9980 by Hynek Schlawack in branch 'default': #14835: Make plistlib output empty arrays & dicts like OS X http://hg.python.org/cpython/rev/9e64084f9980 |
|||
| msg161864 - (view) | Author: Hynek Schlawack (hynek) * (Python committer) | Date: 2012年05月29日 10:10 | |
Thank you for your contribution! But please help Pam to work out your contribution form. |
|||
| msg161894 - (view) | Author: Sidney San Martín (ssm) * | Date: 2012年05月29日 15:37 | |
Thanks Hynek, awesome! It looks like it’s in now. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:30 | admin | set | github: 59040 |
| 2012年05月29日 15:37:32 | ssm | set | messages: + msg161894 |
| 2012年05月29日 10:10:26 | hynek | set | status: open -> closed resolution: fixed messages: + msg161864 stage: patch review -> resolved |
| 2012年05月29日 10:08:16 | python-dev | set | nosy:
+ python-dev messages: + msg161863 |
| 2012年05月29日 07:59:46 | hynek | set | messages: + msg161859 |
| 2012年05月27日 17:40:16 | ssm | set | files:
+ plistlib_empty_element_test.patch messages: + msg161713 |
| 2012年05月25日 10:33:48 | ronaldoussoren | set | messages: + msg161564 |
| 2012年05月25日 10:29:00 | ronaldoussoren | set | messages: + msg161563 |
| 2012年05月25日 10:24:23 | hynek | set | messages: + msg161562 |
| 2012年05月17日 09:43:22 | hynek | set | nosy:
+ ned.deily |
| 2012年05月17日 09:41:45 | hynek | set | nosy:
+ hynek stage: patch review versions: - Python 3.1, Python 3.4 |
| 2012年05月16日 22:17:23 | ssm | create | |