homepage

This has been split off from #14127 at Antoine's request.
The attached patch adds support for keyword-only arguments to the PyArg_ParseTupleAndKeywords() family of functions. Includes doc and test.
I used '$' to indicate "all parameters after this are keyword-only"; since they must also be optional it must follow a '|'. (I would have used '*' but we already use that for 'U*' 's* etc.)
The patch already received one review from Greg P. Smith on the previous issue; the patch I'm attaching here is the second revision incorporating his suggestions.

Why do you force them to be optional?

It frankly never occurred to me that you'd want mandatory keyword-only arguments. Implementing them as optional-only was easy; I'm not sure but making them possibly mandatory (or both!) might complicate matters.
Is there a use case for 'em?

2012年3月15日 Larry Hastings <report@bugs.python.org>:
>
> Larry Hastings <larry@hastings.org> added the comment:
>
> It frankly never occurred to me that you'd want mandatory keyword-only arguments. Implementing them as optional-only was easy; I'm not sure but making them possibly mandatory (or both!) might complicate matters.
>
> Is there a use case for 'em?
No idea, but at some point we might want them and it parallels the
Python interface.

How about we leave it for now, and if we need it later we can fix the implementation. Adding that feature won't break existing calls--we'll just permit $ to occur before/without | in the format string.

BTW, I have the os.utime patch nearly ready for review; it works, it just needs doc and test. But it's dependent on this patch--and it'd be smoother if #14127 were finished too. So I'll hold off on posting the new patch until the fates of these two are decided.

I want #14325 to go in first.

Attached is r3 of my patch incorporated Benjamin's suggestions.
> I want #14325 to go in first.
Why do you care? If I get signoff before 14325 does please explain to me why I should wait. They don't touch the same lines; should be a clean merge no matter who goes first.

Shouldn't using vgetargs1 with '$' in the format string just be an error? vgetargs1 doesn't know anything about keyword arguments.

> Shouldn't using vgetargs1 with '$' in the format string just be
> an error? vgetargs1 doesn't know anything about keyword arguments.
Thank you for catching that! Serves me right for search-and-destroy style development--I'm not that familiar with getargs.c.
Fixed, which is to say I removed that gunk, in attached patch #4 against current trunk.

Incorporated the latest round of suggestions from Benjamin's most recent--and very thorough!--review. Thanks, Benjamin!

Anyone else? Or can I get the go-ahead?

Did you not see Georg's comments?

Whoops! Actually, I did. But then I promptly forgot about them. They're now all incorporated; please see attached patch.

Fine with me now.
2012年3月19日 Larry Hastings <report@bugs.python.org>:
>
> Larry Hastings <larry@hastings.org> added the comment:
>
> Whoops! Actually, I did. But then I promptly forgot about them. They're now all incorporated; please see attached patch.
>
> ----------
> Added file: http://bugs.python.org/file24955/larry.parsekwonly.diff.7.txt
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue14328>
> _______________________________________

New changeset 052779d34945 by Larry Hastings in branch 'default':
Issue #14328: Add keyword-only parameters to PyArg_ParseTupleAndKeywords.
http://hg.python.org/cpython/rev/052779d34945