This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年12月12日 05:41 by marco, last changed 2022年04月11日 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue13586.patch | roger.serwy, 2011年12月17日 19:25 | review | ||
| find_keep_open.patch | roger.serwy, 2011年12月18日 04:39 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 17593 | open | ZackerySpytz, 2019年12月13日 19:28 | |
| Messages (9) | |||
|---|---|---|---|
| msg149276 - (view) | Author: Marco Scataglini (marco) | Date: 2011年12月12日 05:41 | |
Entering the Replace dialog (by ctrl+h or from Edit/Replace... menu) with a selection does not auto-magically have the selected text in the find field. This is not consistent with the other find functions (ctrl+f: Find...; alt+F3: Find in Files...; ctrl+F3: Find Selection) where the highlighted text automatically entered in the find field. |
|||
| msg149647 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2011年12月17日 00:01 | |
In 3.2 on Win 7, selected text *is* put in the 'find' field of Replace boxes, just as with Find boxes, just as it should be. So there is something specific either to 2.7 (which is unusual, since the code base in mostly the same, but possible) or to your OS. What are you running Python with? |
|||
| msg149663 - (view) | Author: Marco Scataglini (marco) | Date: 2011年12月17日 06:41 | |
Win 7 Pro 32bit. |
|||
| msg149697 - (view) | Author: Roger Serwy (roger.serwy) * (Python committer) | Date: 2011年12月17日 19:25 | |
On Linux using 2.7.1 and 3.2, the Replace dialog does not contain the selected text in the Find field. The find functionality that copies the selected text was introduced in 868ff0dfabd2 on 2002年11月06日. Unfortunately it wasn't added to the Replace Dialog code. The attached patch (against 3.3a0) adds this functionality to Replace Dialog and also removes some non-functional (arguably broken) code. |
|||
| msg149734 - (view) | Author: Marco Scataglini (marco) | Date: 2011年12月18日 02:19 | |
To check on 3.2 I installed a fresh Python 3.2.1.1 on Win7 x86 32bit and it has the same problem. So this issues is valid on 2.7.2.1 and 3.2.1.1 I --dry-run Roger patch on both 2.7 and 3.2 with no errors or warnings messages and after patching it fixes the issue on both versions. |
|||
| msg149735 - (view) | Author: Terry J. Reedy (terry.reedy) * (Python committer) | Date: 2011年12月18日 03:01 | |
I am running 3.2.2 on 64-bit Win7Pro, which should not make a difference. So why did ^H work right for me yesterday and not for Marco today. Retrying with fresh IDLEs I discovered the following: selections do not initially appear in the find part of a Replace box (^H). But after selecting and opening a Find box (^F) with something selected, the same text appears in Replace boxes regardless of the actual selection, even if there is no selection -- until another Find box is opened. So I was fooled yesterday because I tried ^F first to see what the 'correct' behavior was and then did ^H with the same selection. And I did the same in both Shell and Edit windows. When testing, order matters ;-). I discovered something else I am not sure is what we want. Clicking Find in a Replace box leaves the box open so one can Find again. Clicking Find in a Find box closes it. So you need ^F and Find to re-search. |
|||
| msg149737 - (view) | Author: Marco Scataglini (marco) | Date: 2011年12月18日 04:07 | |
To follow on Terry thought, I think find dialog box should stay open when 'Find' button is pressed, since there is a 'close' button to close it. That would also be a more accepted behavior similar to all the other editors I know. And on silly UI design notes: The 'close' button should be at the bottom instead of the top (and have a capital C) ctrl+f 'Find' button should say 'Find Next' like most other editors and also since that is what it does. |
|||
| msg149812 - (view) | Author: Marco Scataglini (marco) | Date: 2011年12月19日 02:18 | |
Thank you Roger find_keep_open.patch works, but now that brings me to issue13630 that I thought was existing, and now this confirms it. |
|||
| msg358353 - (view) | Author: Zackery Spytz (ZackerySpytz) * (Python triager) | Date: 2019年12月13日 19:55 | |
I've created a pull request for this issue. Please take a look. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:24 | admin | set | github: 57795 |
| 2019年12月13日 19:55:46 | ZackerySpytz | set | nosy:
+ ZackerySpytz messages: + msg358353 |
| 2019年12月13日 19:28:50 | ZackerySpytz | set | pull_requests: + pull_request17065 |
| 2017年06月30日 00:27:01 | terry.reedy | set | assignee: terry.reedy versions: + Python 3.6, Python 3.7, - Python 2.7, Python 3.4, Python 3.5 |
| 2015年09月07日 17:30:24 | markroseman | set | nosy:
+ markroseman |
| 2014年10月03日 03:18:32 | terry.reedy | set | stage: needs patch -> patch review versions: + Python 3.5, - Python 3.3 |
| 2013年06月15日 18:45:54 | terry.reedy | set | versions: + Python 3.3, Python 3.4, - Python 3.2 |
| 2011年12月19日 02:18:30 | marco | set | messages: + msg149812 |
| 2011年12月18日 04:39:43 | roger.serwy | set | files: + find_keep_open.patch |
| 2011年12月18日 04:07:12 | marco | set | messages: + msg149737 |
| 2011年12月18日 03:01:51 | terry.reedy | set | messages: + msg149735 |
| 2011年12月18日 02:19:03 | marco | set | messages:
+ msg149734 versions: + Python 3.2 |
| 2011年12月17日 19:25:44 | roger.serwy | set | files:
+ issue13586.patch nosy: + roger.serwy messages: + msg149697 keywords: + patch |
| 2011年12月17日 06:41:39 | marco | set | messages: + msg149663 |
| 2011年12月17日 00:02:29 | terry.reedy | set | title: Replace selected not working/consistent with find -> IDLE: Replace selected not working/consistent with find |
| 2011年12月17日 00:01:57 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg149647 stage: needs patch |
| 2011年12月12日 05:41:52 | marco | create | |