This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年05月31日 09:16 by tarek, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| p7g-run-cleanup.diff | eric.araujo, 2011年06月10日 16:10 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg137348 - (view) | Author: Tarek Ziadé (tarek) * (Python committer) | Date: 2011年05月31日 09:16 | |
All actions in packaging.run need to respect a basic exit convention 0/1. This is important because pysetup will be used in automated scripts so the caller needs to know wether the call failed or succedeed. Example: pysetup install project => sys,exit(0 or 1) |
|||
| msg137355 - (view) | Author: Tarek Ziadé (tarek) * (Python committer) | Date: 2011年05月31日 10:21 | |
fixed install in http://hg.python.org/cpython/rev/ebff46b232ed |
|||
| msg138097 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2011年06月10日 16:10 | |
Here’s a patch adding "return 1" after all errors, unifying the use of logging and cleaning up a few things (like moving KeyboardInterrupt handling from the _run function up to the main function). |
|||
| msg138098 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2011年06月10日 16:11 | |
BTW, some functions do not explicitly return 0, but this is okay: they will return None, which is a boolean false value, which is understood as 0 by sys.exit. |
|||
| msg141351 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2011年07月29日 12:35 | |
New changeset 998566bf7fba by Éric Araujo in branch 'default': Let all pysetup actions return a meaningful 0 or 1 exit code (#12222). http://hg.python.org/cpython/rev/998566bf7fba |
|||
| msg141378 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2011年07月29日 13:47 | |
I committed my patch, except for one change in the run action. It returns the dist.Distribution instance, which is needed by test_uninstall and not trivial to fix. I tried changing the code to use Distribution and command objects directly but suddenly the --prefix option was not respected, so I stopped after a few tries. |
|||
| msg144996 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2011年10月06日 11:24 | |
New changeset ab125793243f by Éric Araujo in branch 'default': Fix return code of "pysetup run COMMAND" (closes #12222) http://hg.python.org/cpython/rev/ab125793243f |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:18 | admin | set | github: 56431 |
| 2011年10月06日 11:24:05 | python-dev | set | status: open -> closed resolution: fixed messages: + msg144996 stage: resolved |
| 2011年07月29日 13:47:44 | eric.araujo | set | messages: + msg141378 |
| 2011年07月29日 12:35:19 | python-dev | set | nosy:
+ python-dev messages: + msg141351 |
| 2011年06月10日 16:11:46 | eric.araujo | set | messages: + msg138098 |
| 2011年06月10日 16:10:38 | eric.araujo | set | files:
+ p7g-run-cleanup.diff keywords: + patch messages: + msg138097 |
| 2011年06月06日 16:13:10 | eric.araujo | set | dependencies: + pysetup --search should return non-zero when a dist is not installed and print a message stating the fact. |
| 2011年05月31日 10:21:50 | tarek | set | messages: + msg137355 |
| 2011年05月31日 09:16:12 | tarek | create | |