Memory leak in IndicatorObjectEntryProxyRemote::GetPixbuf

Bug Description

In IndicatorObjectEntryProxyRemote::GetPixbuf(), a GMemoryInputStream is created and closed, but not properly g_object_unref()-ed.

I've only checked this with the Unity in natty-updates. I believe the oneiric one has done away with the affected code and is not affected by this bug.

Steps to reproduce:
1. Start up indicator-multiload
2. Set the indicator-multiload update interval to something really short, say 500 ms.
3. Wait 24h or so.
4. Check the memory usage of Compiz (~300-400M)

Patch to fix this memory leak. Verified from local testing to work.

Fixed in unity trunk.

i have an sru branch for Natty already if you could propose this fix to lp:unity3.0 (I could do that too) we can get this SRU'ed soonish as well

(missed you already had Ubuntu SRU sponsered)

Currently in the unapproved queue awaiting SRU processing, removing ubuntu-sponsors subscription.

Thanks.

Hi Omer! The upload looks good, *except* the addition of

--- unity-3.8.16.orig/.bzrignore.THIS
+++ unity-3.8.16/.bzrignore.THIS

Please re-upload without this extra file and we should be able to accept it into natty-proposed.

Also please add a basic SRU report to this bug, per

https://wiki.ubuntu.com/StableReleaseUpdates

Hello Chow, or anyone else affected,

Accepted unity into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I'm not 100% sure if it's related to this bug but since I upgraded to unity 3.8.16-0ubuntu1~natty3 I have trouble with my external LCD screen.

I can get to the login prompt but once authenticated, the screen goes black. When this occurs, I still can have my display back if I unplug my external monitor, my laptop's screen goes on and all work fine on this screen (except that some applets failed to load the first time).

Note that I normally only use my external monitor as my primary and my laptop's screen is turned off by default. This seems to trigger the bug. I was able to find workaround to have my external LCD working :

# Set my external LCD as primary
$ xrandr --output VGA1 --primary

# Turn off laptop's screen
$ xrandr --output LVDS1 --off

On 13/10/2011 23:23, Simon Déziel wrote:
> I'm not 100% sure if it's related to this bug but since I upgraded to
> unity 3.8.16-0ubuntu1~natty3 I have trouble with my external LCD screen.
>
> I can get to the login prompt but once authenticated, the screen goes
> black. When this occurs, I still can have my display back if I unplug my
> external monitor, my laptop's screen goes on and all work fine on this
> screen (except that some applets failed to load the first time).
>
> Note that I normally only use my external monitor as my primary and my
> laptop's screen is turned off by default. This seems to trigger the bug.
> I was able to find workaround to have my external LCD working :
>
> # Set my external LCD as primary
> $ xrandr --output VGA1 --primary
>
> # Turn off laptop's screen
> $ xrandr --output LVDS1 --off
>

It's probably not this bug. The fix for this bug is a one-liner that has no
visual impact at all. You should try downgrading to 3.8.16-0ubuntu1~natty2 and
seeing if the issue still persists. natty3 fixes bug #761409 as well, but I
don't think your issue is related to that either.

--
Kind regards,
Loong Jin

@Chow, you are right as downgrading to 3.8.16-0ubuntu1~natty2 didn't help. Thanks for your help.

This bug was fixed in the package unity - 3.8.16-0ubuntu1~natty3

---------------
unity (3.8.16-0ubuntu1~natty3) natty-proposed; urgency=low

* src/PanelTray.cpp:
* src/PanelTray.h:
- make systray behave nice when the whitelist is on (LP: #761409)
* src/IndicatorObjectEntryProxyRemote.cpp:
- Fix leak of GMemoryInputStream. (thx hyperair) (LP: #816632)
-- Omer Akram <email address hidden> 2011年9月06日 00:09:33 +0500