[FFe/UIFe] Unity launcher gets cluttered when having multiple partitions and/or external volumes attached
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Released
|
High
|
John Lea | ||
| Unity |
Fix Released
|
Medium
|
Andrea Azzarone | ||
| ubuntu-docs (Ubuntu) |
Won't Fix
|
Low
|
Unassigned | ||
| Raring |
Won't Fix
|
Low
|
Unassigned | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Andrea Azzarone | ||
| Raring |
Won't Fix
|
Undecided
|
Unassigned | ||
Bug Description
Having a multi-boot system, multiple partitions, USB keys, SD cards and external hard drives makes Unity launcher cluttered very quick (see screenshot).
To resolve this issue the following changes are required:
1) It should be possible to remove specific file system icons from the Launcher by un-checking the "Unlock from Launcher" option (or dragging to the trash).
2) In the case of non-removable file systems, the system should remember these settings so that rebooting will not return these icons to the Launcher.
3) In the case of removable file systems (USB keys, SD cards, etc...), if a removable file system is removed and then re-attached it should re-appear in the Launcher. If the removable file system is not removed and the user has removed it's icon from the Launcher, the icon should not return to the Launcher even if the computer is re-booted.
4) All 'specific file system' icons that the user has removed from the Launcher should be displayed in the Dash file Lens in the "Favourite Folders/Folders" category. This allows the user to re-add these icons to the Launcher at a later date.
Mailing list links
------------------
# doc: https:/
# translator: https:/
Related branches
- Neil J. Patel (community): Approve
- Tim Penhey (community): Approve
-
Diff: 1452 lines (+575/-447) 11 files modifiedapiUnityCore/GLibWrapper.cpp (+4/-1)
com.canonical.Unity.gschema.xml (+4/-9)
plugins/unityshell/src/DeviceLauncherIcon.cpp (+209/-240)
plugins/unityshell/src/DeviceLauncherIcon.h (+12/-9)
plugins/unityshell/src/DeviceLauncherSection.cpp (+98/-70)
plugins/unityshell/src/DeviceLauncherSection.h (+34/-20)
plugins/unityshell/src/DevicesSettings.cpp (+136/-62)
plugins/unityshell/src/DevicesSettings.h (+50/-33)
plugins/unityshell/src/LauncherController.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+5/-2)
plugins/unityshell/unityshell.xml.in (+22/-0)
- Paweł Stołowski (community): Approve
-
Diff: 615 lines (+372/-35) 3 files modifiedapisrc/daemon.vala (+95/-4)
src/folder.vala (+236/-31)
tests/manual/folders.txt (+41/-0)
- Marco Trevisan (Treviño): Approve
-
Diff: 3673 lines (+2330/-692) 35 files modifiedapicom.canonical.Unity.gschema.xml (+3/-3)
launcher/AbstractVolumeMonitorWrapper.h (+3/-4)
launcher/CMakeLists.txt (+6/-3)
launcher/DeviceLauncherSection.cpp (+23/-27)
launcher/DeviceLauncherSection.h (+17/-7)
launcher/DeviceNotificationDisplay.h (+45/-0)
launcher/DeviceNotificationDisplayImp.cpp (+82/-0)
launcher/DeviceNotificationDisplayImp.h (+46/-0)
launcher/DevicesSettings.h (+26/-48)
launcher/DevicesSettingsImp.cpp (+133/-125)
launcher/DevicesSettingsImp.h (+50/-0)
launcher/FileManagerOpener.h (+45/-0)
launcher/FileManagerOpenerImp.cpp (+35/-0)
launcher/FileManagerOpenerImp.h (+39/-0)
launcher/Launcher.cpp (+12/-2)
launcher/Launcher.h (+5/-0)
launcher/LauncherController.cpp (+6/-4)
launcher/LauncherController.h (+1/-0)
launcher/LauncherControllerPrivate.h (+2/-0)
launcher/Volume.h (+62/-0)
launcher/VolumeImp.cpp (+294/-0)
launcher/VolumeImp.h (+68/-0)
launcher/VolumeLauncherIcon.cpp (+262/-382)
launcher/VolumeLauncherIcon.h (+27/-43)
plugins/unityshell/src/unityshell.cpp (+0/-5)
plugins/unityshell/unityshell.xml.in (+0/-20)
po/POTFILES.in (+2/-1)
tests/CMakeLists.txt (+8/-2)
tests/gmockmount.c (+167/-0)
tests/gmockmount.h (+55/-0)
tests/gmockvolume.c (+120/-13)
tests/gmockvolume.h (+14/-2)
tests/test_device_launcher_section.cpp (+11/-1)
tests/test_volume_imp.cpp (+163/-0)
tests/test_volume_launcher_icon.cpp (+498/-0)
- Screenshot-1.png Edit (164.4 KiB, image/png)
- BootDmesg.txt Edit (50.1 KiB, text/plain; charset="utf-8")
- CurrentDmesg.txt Edit (1.8 KiB, text/plain; charset="utf-8")
- Dependencies.txt Edit (4.9 KiB, text/plain; charset="utf-8")
- Lspci.txt Edit (12.0 KiB, text/plain; charset="utf-8")
- Lsusb.txt Edit (662 bytes, text/plain; charset="utf-8")
- ProcCpuinfo.txt Edit (1.5 KiB, text/plain; charset="utf-8")
- ProcInterrupts.txt Edit (1.7 KiB, text/plain; charset="utf-8")
- ProcModules.txt Edit (2.2 KiB, text/plain; charset="utf-8")
- UdevDb.txt Edit (130.2 KiB, text/plain; charset="utf-8")
- UdevLog.txt Edit (264.5 KiB, text/plain; charset="utf-8")
- UnitySupportTest.txt Edit (997 bytes, text/plain; charset="utf-8")
- XorgLog.txt Edit (60.9 KiB, text/plain; charset="utf-8")
- XorgLogOld.txt Edit (56.3 KiB, text/plain; charset="utf-8")
- Xrandr.txt Edit (5.1 KiB, text/plain; charset="utf-8")
- xdpyinfo.txt Edit (9.7 KiB, text/plain; charset="utf-8")
- drives
+ Unity launcher gets cluttered when having multiple partitions and/or
+ external volumes attached
I have also reported exactly these two issues, but focused on the questionmark icon instead of the cluttered launcher, see bug #710809
Thanks for the report. I think you are correct, I've sent a proposed
solution to John Lea in the design team and will ask him to update the
bug report accordingly.
status confirmed
Mark
I to find this annoying. I dont want USB's and CD-rom's on my unity launcher bar. But i think it is ok that they show up as desktop icons. The other partitions on my hdd with other systems i dont want in my unity launcher nor as desktop icons. Would love for an easy or complicated howto to hide the unwanted elements.
Sorry if I'm asking a question with obvious answer, but is this problem solved? I would really like to blacklist some of my partitions from showing in launcher. A simple dialog box titled Blacklist (or something like this), with all storage devices listed and checkbox for each one would be the perfect solution for me (what is checked - it doesn't show in launcher). Or even an edit box (or gconf option) where blacklisted paths could be entered manually (something like Mount screenlet) would be fine.
@zzarko: the status of the bug in both unity and unity-2d is 'Confirmed', meaning it isn’t fixed yet. There has been design work to solve it though, as suggested by the status of the bug for the Ayatana Design project.
This bug was fixed in the package unity - 4.6.0-0ubuntu1
---------------
unity (4.6.0-0ubuntu1) oneiric; urgency=low
* New upstream release.
- compiz crashed with SIGSEGV in __strlen_sse2() (LP: #814619)
- PlacesHomeView:
- PluginAdapter:
- Launcher - Make Launcher left of screen reveal more responsive and less
prone to false positives (LP: #765819)
- Launcher - clicking on a App launcher icon incorrectly un-minimizes
windows (LP: #783434)
- Unity doesn't get any mouse wheel scroll event in Indicators InputArea
(LP: #814574)
- Unity launcher gets cluttered when having multiple partitions and/or
external volumes attached (LP: #713423)
- Unity panel menus and indicators slow to respond. Too much lag.
(LP: #742664)
- In Unity the distinction between GVolume, GDrive and GMount is a bit
confusing. (LP: #799890)
- Launcher - When a item is deleted by dragging to Trash, the trash should
pulse once before the Launcher disappears (LP: #750311)
- ccsm needs an option to change launcher opacity (LP: #815032)
- add a ccsm option to hide volumes in launcher (LP: #794707)
- scale plugin doesn't work as desired when "Click Desktop To Show
Desktop" is true (LP: #810315)
- mute/unmute sound when user clicks on sound applet using scroll button
or middle mouse button (LP: #609860)
- Secondary activate (i.e. middle click) support for indicators advanced
usage (LP: #812933)
* debian/control:
- dep on latest libunity-misc
- dep on latest nux
- add build-dep on libgnome-
* debian/rules:
- bump libunity-core-4.0-4 shlib for ABI break
- don't ship unity dialogs right now. Not ready for alpha quality
* distro-patch the grey to darker grey (until the blur is done in nux)
* Switch to dpkg-source 3.0 (quilt) format
* debian/
- revert a removed API making unity-2d not building
-- Didier Roche <email address hidden> 2011年8月01日 19:53:15 +0200
Tested with a USB stick and fails the following tests:
- No 'Keep in Launcher' option displayed (see item 1 in the bug description)
- Unable to test item 3 due to lack of 'Keep in Launcher' option
- Unable to test item 4 for the same reason.
Reverting to confirmed
@JohnLea
"1) It should be possible to remove specific file system icons from the Launcher by un-checking the "Keep in Launcher" option (or dragging to the trash)."
What happens if a usb icon is dragged to the trash: it should be un-pinned or it should be ejected?
@Andrea: I think we should dump blacklisted devices in a file formatted like your ~/.gtk-bookmarks, stored in something like ~/.local/
The gtk-bookmarks file has a format ala:
<uri> [label]
<uri> [label]
...
So for my particular setup it could look like:
$ cat ~/.local/
file://
file://
$
And the files lens would just parse this file and append it to the Folders category.
Given all this, I don't know if unity supports dragging devices into the launcher yet? So that may be a work item as well.
Why not use gsettings? Currently we use it to save a whitelist, I have already converted to a blacklist.
In the lense the blacklist become a whitelist. Is it possible something like that in a lense?
That would create a dep from the lenses on the Unity gsettings schemas which is no catastrophe, but not really elegant either... It does have the advantage of giving us change notifications for free though.
I was also considering adding something to libunity on this because both the unity, files lens, and others might be interested in this data. But that may grow the task out of scope for now as a good api needs some thought...
Ok, return to the solution of comment #10. To implement dnd of devices into the launcher i think we should use a prefix, something like:
device:///....
Instead of using a path what about using the uuid? So
device:
uuid works for (most) flash and hard drives, but not necessarily network mounts, optical drives or other... But I guess Unity needs some way to figure out that something is a device in order to place it at the correct position in the Launcher.
I agree that using mount path is slightly hacky though - but it will be reliable for almost all users. Eeek - except I just discover that CD-ROMs are mounted under /media/$disk_label :-/
Network mounts are not considered in Unity and IMHO it makes no sense blacklist a cd-rom.
@andyrock
To answer your question "What happens if a usb icon is dragged to the trash: it should be un-pinned or it should be ejected?"
It should be ejected (and of course also un-pinned)
@John Lea: a cd-rom icon should have the quicklist item: "Keep in launcher"?
@andyrock
re. your question "a cd-rom icon should have the quicklist item: "Keep in launcher"?"
Yes, a cd-rom should have the quicklist item "Keep in launcher". A user might not want their cd-rom displayed in their Launcher. They can always add it back to the Launcher at a later date by searching for it in the Dash, and drag and dropping it back into the Launcher, see point 4 in the bug description.
thanks!
Update: Unity 6.4 is revision 2632, so this is actually fix committed for Unity 6.6.
- external volumes attached
+ [FFe/UIFe] Unity launcher gets cluttered when having multiple partitions
+ and/or external volumes attached
Status changed to 'Confirmed' because the bug affects multiple users.
Ok, +1 from the Docs Team.
Status changed to 'Confirmed' because the bug affects multiple users.
A type of "Drawer", might also be another solution for this. i.e. :
I think this seems sensible, but I'm a little unclear about what I'm supposed to be approving. I see this was apparently partially, but not completely, fixed in Oneiric. What's changing now? How bad is the current situation?
Oh, and when can this land?
Setting to Incomplete, please reset to New once you've provided this info. Thanks :-)
It was not fixed in Oneiric unfortunately, but it is ready to land now ;-)
This is a much requested change, giving the user the ability to configure their Launcher icons as they please. For example this change would enable a user to place their workspace switcher launcher iconat the top of their launcher if they so choose. This functionality has been requested by many, many, many users since we originally launched Unity.
Approved, please go ahead ASAP
This bug was fixed in the package unity - 6.6.0-0ubuntu1
---------------
unity (6.6.0-0ubuntu1) quantal-proposed; urgency=low
* New upstream release.
- Fixes non-escaped character sequences in dash previews (LP: #1039020)
- Updated background layer for preview cover-art and details panels
to be 10% low-light
- Expand a PlacesGroup if it is the only category that contains results
(LP: #950710)
- Update unity autopilot tests to match autopilot API
- Updated the convert files to fix some typos in the key names
- Add gmodule dependency
- Activate proper result if the categories aren't displayed in-order
(LP: #1040101)
- Refactor device launcher icons (LP: #713423)
- LauncherController: make the controller enable the launcher struts,
based on hide-mode option (LP: #1044005)
- Launcher: make always possible to drag an icon to the bottom or top
of its sub list (LP: #1043968)
- Don't desat bfb/hud icon in DNDReset (LP: #1043963)
- Progressively adjust the speed of the minimize animation. First
time it is used is slower, then speeds up the more it is used.
(LP: #1017510)
- Implement new ordering of categories for home lens. (LP: #1043915)
- UnityWindow now implements ScaleWindowInte
- Launcher: restore an icon position after that the dragging has been
cancelled (LP: #955561)
- LauncherDragWindow: cancel drag on window mapped/unmapped
(LP: #1044723)
- Now there is a check of an override color in RefreshColor (which is
called when a PropertyNotify event happens). Also added a check in
FullySatu
- Queue redraw after cover-art texture is updated from a url/file source.
(LP: #1043947)
- Fixed ability to delete glib::Source wrapper during its callback
(LP: #1044823)
- Close preview when dash is hidden. (LP: #1045298)
- LauncherModel: rewrite the Reordering functions to keep the icon
priority deltas (LP: #761155)
- Make sure we can pass extra hints when activating preview actions.
(LP: #1046352)
- UnityWindow: scale window code improved (LP: #1033935)
- The mouse will now cause the HUD buttons to change selection
(LP: #1042692)
- "Alt+Space" shortcut to reveal the window menu is not hardcoded, but a
Compiz key option. " (Hold)" should also be translated. Made all
Compiz plug-in names and all Compiz plug-in option names in
- remove unity --reset, it's not anymore really needed now that we are
in stable days of unity and we moved to gsettings
- Removed the variables 'oldPrev' and 'oldNext' which got assigned the
value NULL, but then were never used
- Fixed the size of the previews to 770x380 pixels. (LP: #1045243)
- UnityWindow: use smart pointers, use static close_icon (with dynamic
state) and PanelStyle context (LP: #1033935) (LP: #1045127)
(LP: #1046124) (LP: #1046126)
- Remove everything in the #ifndef USE_MODERN_
the ifdefs alltogether. unity now requires compiz...
removed: udo udp udt
Status changed to 'Confirmed' because the bug affects multiple users.
raring has seen the end of its life and is no longer receiving any updates. Marking the raring task for this ticket as "Won't Fix".