newer HECI module fixes build with CONFIG_HECI=y

Bug Description

SRU justification:

Impact: The HECI module define a switch of debug message, which symbol name
conflicts with another symbol in "arch/x86/kernel/entry_32.S".

Fix: Change the symbol name from debug to heci_debug so that the make wont
fail if "CONFIG_HECI=y".

Testcase: Compile kernel with CONFIG_HECI=y

---

The jaunty git tree's version of ubuntu/heci defines
extern int debug;
which conflicts with Linux's own symbol of that name on AMD64 at least. (seems to be a kprobe entry in entry_64.S)

I looked at upstream, and heci-5.0.0.30.tar.gz from
https://sourceforge.net/project/showfiles.php?group_id=193428&package_id=227758
renamed the variable to heci_debug. (I only checked the latest, 5.0.0.30, so I don't actually know when this fix happened.)

This only affects custom configs with CONFIG_HECI=y, not the default =m.
Manually changing debug to heci_debug where it occurs in the current ubuntu/heci subtree is sufficient to make Linux build with my config, so you could just patch that if you want to fix this bug without breaking the Jaunty freeze too badly.

Both Jaunty and Intrepid has this bug.

I will fix it

This bug was fixed in the package linux - 2.6.28-11.36

---------------
linux (2.6.28-11.36) jaunty; urgency=low

[ Amit Kucheria ]

* Updating imx51 configs one more time
* Disable CONFIG_UEVENT_HELPER_PATH

[ Anton Veretenenko ]

* SAUCE: sony-laptop: add support for Sony Vaio FW series function/media
keys
- LP: #307592

[ Brad Figg ]

* Have AUFS use current VFS APIs so it can build with or without
AppArmor.

[ Bryan Wu ]

* Build-in "Ram block device support" to boot up with initramfs
- LP: #329098
* Remove brd module from iop32x modules list
- LP: #329098
* Increase the CONFIG_BLK_DEV_RAM_SIZE to 8192 on i.MX51

[ Ike Panhc ]

* SAUCE: Fixing symbol name in HECI module
- LP: #336549

[ Manoj Iyer ]

* SAUCE: Added quirk for Ralink rt2870 802.11n USB driver
- LP: #326621

[ Upstream Kernel Changes ]

* udf:SAUCE (drop after 2.6.30): Fix oops when invalid character in
filename occurs
- LP: #321606

-- Stefan Bader <email address hidden> 2009年3月20日 16:52:08 +0100

Thanks for doing all this work.
Unfortunately I am not technical enough to solve the problem
My question:
When does Jaunty get the heci-5.0.0.30 version due automatic updates?
If not is there a binary package to download for my Linux 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux kernel?
Regards,

Hi Michael,

Thanks for your question about this issue

I was thinking about upgrade to heci-5.0.0.30 to fix this issue, but I can not find changelog from any place (maybe I miss that), so I decide to keep on the 3.2.0.24 and change the symbol name to fix the issue

Fortunately, the linux-2.6 upstream has including heci-5.0.0.30, so we will have the lastest heci driver with Karmic.

You can have that kernel binary package by installing or upgrading to Jaunty that just release.
You may try http://www.ubuntu.com/getubuntu/download

Thanks a million times !
---Michael

Accepted linux into intrepid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

This bug was fixed in the package linux - 2.6.27-14.41

---------------
linux (2.6.27-14.41) intrepid-proposed; urgency=low

[ Stefan Bader ]

* Revert "SAUCE: input: Blacklist digitizers from joydev.c"
- LP: #300143

linux (2.6.27-14.40) intrepid-proposed; urgency=low

[ Amit Kucheria ]

* Disable DEVKMEM for all archs on Intrepid
- LP: #354221
* SAUCE: Quirk for BT USB device on MacbookPro to be reset before use
- LP: #332443

[ Andy Isaacson ]

* LIRC_PVR150: depends on VIDEO_IVTV
- LP: #341477
* SAUCE: FSAM7400: select CHECK_SIGNATURE
- LP: #341712

[ Andy Whitcroft ]

* SAUCE: hotkey quirks for various Zepto Znote and Fujitsu Amilo laptops
- LP: #330259
* SAUCE: unusual devs: add an entry for the ScanLogic SL11R-IDE 0.78
- LP: #336189

[ Anton Veretenenko ]

* SAUCE: sony-laptop: add support for Sony Vaio FW series function/media
keys
- LP: #307592

[ Ayaz Abdulla ]

* SAUCE: forcedeth: msi interrupt fix
- LP: #288281

[ Chuck Short ]

* SAUCE: [USB] Unusual Device support for Gold MP3 Player Energy
- LP: #125250

[ Ike Panhc ]

* squashfs: correct misspelling
- LP: #322306
* SAUCE: Fixing symbol name in HECI module
- LP: #336549
* Copy header files for various kernel media driver
- LP: #322732

[ Stefan Bader ]

* SAUCE: vgacon: Return the upper half of 512 character fonts
- LP: #355057
* SAUCE: input: Blacklist digitizers from joydev.c
- LP: #300143

[ Upstream Kernel Changes ]

* libata: make sure port is thawed when skipping resets
- LP: #269652
* x86-64: fix int 0ドルx80 -ENOSYS return
- LP: #339743
* rt2x00: Fix race conditions in flag handling
- LP: #258985
* USB: cdc-acm: Add another conexant modem to the quirks
- LP: #323829
* Bluetooth: Add fine grained mem_flags usage to btusb driver
- LP: #268502
* Bluetooth: Handle bulk URBs in btusb driver from notify callback
- LP: #268502
* Bluetooth: Submit bulk URBs along with interrupt URBs
- LP: #268502
* hwmon: (abituguru3) Match partial DMI board name strings
- LP: #298798
* x86: mtrr: don't modify RdDram/WrDram bits of fixed MTRRs
- LP: #292619
* sis190: add identifier for Atheros AR8021 PHY
- LP: #247889
* ath9k: implement IO serialization
- LP: #373034
* ath9k: AR9280 PCI devices must serialize IO as well
- LP: #373034
* acer-wmi: fix regression in backlight detection
- LP: #333386

-- Stefan Bader <email address hidden> 2009年8月26日 11:48:11 +0200