[FFE][UIFE]Dash - Finesse the placement, movement and behaviour of the 12.10 Dash

Bug #1049593 reported by John Lea
28
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
Critical
John Lea
Music Lens
Fix Released
Critical
Unassigned
Photos Lens
Fix Released
Undecided
Unassigned
Unity
Fix Released
Critical
Unassigned
unity (Ubuntu)
Fix Released
Critical
Unassigned
unity-asset-pool (Ubuntu)
Fix Released
Undecided
Unassigned
unity-lens-music (Ubuntu)
Fix Released
Critical
Unassigned
unity-lens-photos (Ubuntu)
Fix Released
Critical
Unassigned

Bug Description

= Proposed Change =

At the London 12.10 dash sprint we are working on finessing the placement, movement and behaviour of elements in the 12.10 Dash. This bug is requesting a FFE and UIFE to land these fixes.

-------------
Changes include:
- remove preview containers
- default button (normally mapped to same action as left-click) should be focused
- left/right arrows go 20% opc and move further apart, go fully opaque on mouseover
- Clicking outside of dash region does not stop a song preview from playing
- Clicking on the main left hand side preview image in a Dash Preview should close the Preview and return the user to the results view
- Users should be able to exit the Preview and return to the results by right clicking anywhere inside the preview
- tab to move focus between buttons
- Fix display of star ‘Rating’ in App Previews
- Buttons are in 34px height, with 1px inside stroke for unselected, 2px inside stroke for selected
- Buttons should also render the extra_text property of PreviewAction
- add correct category header icons for Dash home
- adjust spacing between categories so the implementation matches design
- category headers should only be focusable if they can be expended
- Dash is not dismissed when something in the other display is clicked
- Dash jumps from one monitor to another in a multi-monitor environment
- On a fresh install, the "filter results" section of all Lenses should be collapsed by default
- update highlight focus to a 106px * 106px square with 2px round corner, 20% opc white
- Files deleted by dragging and dropping from the Dash to the Trash are not removed from the Dash
- Height of lenses nav bar is 40px
- Removing ‘rating’ star filter from app lens
- All results other than app and file icons should become 96px * 96px
- app icons and icons of files that cannot be previewed become 64px * 64px
- When an application is installed direct from a Dash Preview, the Software Centre should not be launched and the Software Centre window should not be opened
- All applications which are a dependency of Ubuntu Desktop should not have an uninstall button in their preview

= Effects on Quantal =

This FFe captures a lot of small bugs/fixes and a couple larger ones. Though we don't expect any issues, the reason there are so many branches linked is that, if there are issues found, we can revert out the individual 'fixes' rather than having to revert out everything.

This should hopefully make it more palatable for getting into Ubuntu. Amongst the branches linked, there are only a couple with large code changes, and they have been developed in isolation of the rest, ready to be reverted out should they cause any issues for beta 2.

= Translations =

unity-lens-applications, unity-lens-music and unity-lens-videos have one new string: "More suggestions"

(this might be captured in another report but just to be absolutely sure adding it here per dpm's request)

Related branches

lp:~mhr3/unity-lens-applications/remove-ratings-filter
Paweł Stołowski (community): Approve
Diff: 87 lines (+7/-27)
2 files modified
src/daemon.vala (+6/-26)
src/schemas.vala (+1/-1)
api
lp:~stolowski/unity-lens-music/price-in-results
Michal Hruby (community): Approve
Diff: 68 lines (+24/-4)
2 files modified
src/daemon.vala (+2/-2)
src/musicstore-collection.vala (+22/-2)
api
lp:~unity-team/unity/see-you-later-flow
Andrea Azzarone (community): Approve
John Lea (community): Approve (design)
Diff: 19 lines (+3/-0)
1 file modified
dash/LensView.cpp (+3/-0)
api
lp:~stolowski/unity-lens-music/personal-content-flag
Michal Hruby (community): Approve
Diff: 35 lines (+3/-0)
3 files modified
src/banshee-scope.vala (+1/-0)
src/musicstore-scope.vala (+1/-0)
src/rhythmbox-scope.vala (+1/-0)
api
lp:~stolowski/unity-lens-files/personal-content-flag
Michal Hruby (community): Approve
Diff: 10 lines (+1/-0)
1 file modified
src/daemon.vala (+1/-0)
api
lp:~stolowski/unity-lens-applications/category-rename
Michal Hruby (community): Approve
Diff: 12 lines (+1/-1)
1 file modified
src/daemon.vala (+1/-1)
api
lp:~gordallott/unity/newbg
Omer Akram (community): Approve
Andrea Azzarone (community): Approve
John Lea (community): Approve (design)
Gord Allott: Pending requested
Diff: 1047 lines (+462/-82)
17 files modified
dash/FilterBar.cpp (+0/-22)
dash/FilterBar.h (+0/-1)
dash/LensView.cpp (+30/-2)
dash/LensView.h (+1/-0)
dash/PlacesGroup.cpp (+85/-22)
dash/PlacesGroup.h (+5/-3)
panel/PanelController.cpp (+14/-0)
panel/PanelController.h (+2/-0)
panel/PanelView.cpp (+146/-2)
panel/PanelView.h (+11/-0)
panel/StandalonePanel.cpp (+8/-6)
plugins/unityshell/src/unityshell.cpp (+1/-0)
unity-shared/DashStyle.cpp (+37/-0)
unity-shared/DashStyle.h (+8/-1)
unity-shared/OverlayRenderer.cpp (+108/-22)
unity-shared/UBusMessages.h (+3/-0)
unity-standalone/StandaloneUnity.cpp (+3/-1)
api
Gord Allott: Pending requested
Diff: 2019 lines (+761/-246)
37 files modified
dash/CoverflowResultView.cpp (+4/-7)
dash/DashController.cpp (+8/-10)
dash/DashController.h (+2/-1)
dash/FilterBar.cpp (+0/-22)
dash/FilterBar.h (+0/-1)
dash/LensBar.cpp (+3/-1)
dash/LensView.cpp (+30/-2)
dash/LensView.h (+1/-0)
dash/PlacesGroup.cpp (+84/-24)
dash/PlacesGroup.h (+5/-3)
dash/previews/ActionButton.cpp (+1/-1)
dash/previews/PreviewContainer.cpp (+45/-30)
launcher/LauncherController.cpp (+1/-1)
manual-tests/Dash.txt (+13/-0)
manual-tests/Preview.txt (+27/-6)
panel/PanelController.cpp (+14/-0)
panel/PanelController.h (+2/-0)
panel/PanelView.cpp (+147/-2)
panel/PanelView.h (+11/-0)
panel/StandalonePanel.cpp (+8/-6)
plugins/unityshell/resources/lens-nav-app.svg (+12/-12)
plugins/unityshell/resources/lens-nav-file.svg (+3/-8)
plugins/unityshell/resources/lens-nav-gwibber.svg (+14/-0)
plugins/unityshell/resources/lens-nav-home.svg (+4/-4)
plugins/unityshell/resources/lens-nav-music.svg (+6/-11)
plugins/unityshell/resources/lens-nav-photo.svg (+6/-11)
plugins/unityshell/resources/lens-nav-video.svg (+8/-9)
plugins/unityshell/src/unityshell.cpp (+31/-27)
plugins/unityshell/src/unityshell.h (+1/-4)
tests/autopilot/unity/tests/test_dash.py (+55/-17)
tests/autopilot/unity/tests/test_hud.py (+51/-16)
unity-shared/DashStyle.cpp (+37/-0)
unity-shared/DashStyle.h (+8/-1)
unity-shared/OverlayRenderer.cpp (+112/-7)
unity-shared/PreviewStyle.cpp (+1/-1)
unity-shared/UBusMessages.h (+3/-0)
unity-standalone/StandaloneUnity.cpp (+3/-1)
api
lp:~unity-team/unity-lens-video/match-latest-design
Paweł Stołowski (community): Approve
Diff: 273 lines (+79/-35)
2 files modified
po/unity-lens-video.pot (+32/-8)
src/unity-lens-video (+47/-27)
api
lp:~unity-team/unity-lens-video/split-online-results
Jim Hodapp (community): Approve (code)
Diff: 150 lines (+61/-35)
1 file modified
src/unity-scope-video-remote (+61/-35)
api
Superseded for merging into lp:unity-lens-video
Unity Videos lens: Pending requested
Diff: 1187 lines (+1153/-0) (has conflicts)
6 files modified
COPYING (+674/-0)
MANIFEST.in (+4/-0)
setup.py (+16/-0)
src/unity-scope-video-remote (+453/-0)
unity-scope-video-remote.service (+3/-0)
video-remote.scope (+3/-0)
api
lp:~stolowski/unity-lens-applications/results-ribbons
Neil J. Patel (community): Approve
Diff: 429 lines (+233/-22)
7 files modified
configure.ac (+1/-1)
src/Makefile.am (+1/-0)
src/daemon.vala (+58/-13)
src/purchase-info-helper.vala (+80/-0)
src/unity-package-search.cc (+81/-3)
src/unity-package-search.h (+4/-0)
vapi/unity-package-search.vapi (+8/-5)
api
lp:~njpatel/unity/fix-application-emblem-category-loading
Marco Trevisan (Treviño): Approve
Diff: 14 lines (+4/-0)
1 file modified
unity-shared/IconLoader.cpp (+4/-0)
api
lp:~unity-team/nux/nux.redirected-views
Neil J. Patel (community): Approve
Diff: 6727 lines (+2510/-1026)
96 files modified
Nux/AbstractCheckedButton.cpp (+1/-1)
Nux/AbstractComboBox.cpp (+2/-2)
Nux/AbstractComboBox.h (+2/-2)
Nux/Area.cpp (+211/-25)
Nux/Area.h (+113/-8)
Nux/BaseWindow.h (+0/-1)
Nux/BasicView.cpp (+46/-0)
Nux/BasicView.h (+42/-0)
Nux/Button.cpp (+25/-8)
Nux/CheckBox.cpp (+0/-2)
Nux/ClientArea.cpp (+74/-125)
Nux/ClientArea.h (+0/-1)
Nux/ColorEditor.cpp (+29/-53)
Nux/ColorPreview.cpp (+1/-1)
Nux/ComboBoxSimple.cpp (+1/-1)
Nux/Coverflow.cpp (+3/-3)
Nux/Coverflow.h (+1/-1)
Nux/CoverflowItem.h (+1/-1)
Nux/EditTextBox.cpp (+1/-1)
Nux/FloatingWindow.cpp (+11/-11)
Nux/FloatingWindow.h (+5/-5)
Nux/GridHLayout.cpp (+1/-1)
Nux/GridVLayout.cpp (+1/-1)
Nux/GroupBox.h (+1/-1)
Nux/GroupBox2.cpp (+1/-1)
Nux/GroupBox2.h (+1/-1)
Nux/HScrollBar.cpp (+4/-4)
Nux/HScrollBar.h (+4/-4)
Nux/HSplitter.cpp (+0/-20)
Nux/HSplitter.h (+1/-1)
Nux/InputArea.cpp (+4/-2)
Nux/InputArea.h (+0/-2)
Nux/LayeredLayout.cpp (+2/-7)
Nux/Layout.cpp (+306/-63)
Nux/Layout.h (+26/-9)
Nux/LinearLayout.cpp (+3/-3)
Nux/MainLoopGLib.cpp (+0/-1)
Nux/Makefile.am (+3/-0)
Nux/MenuBar.cpp (+5/-5)
Nux/MenuBar.h (+1/-1)
Nux/MouseAreaCtrl.cpp (+1/-1)
Nux/MouseAreaCtrl.h (+1/-1)
Nux/Nux.cpp (+1/-0)
Nux/Nux.h (+5/-0)
Nux/NuxTimerTickSource.h (+54/-0)
Nux/PaintLayer.cpp (+9/-0)
Nux/Painter.cpp (+42/-4)
Nux/Painter.h (+7/-0)
Nux/RGBValuator.cpp (+10/-21)
Nux/RGBValuator.h (+9/-9)
Nux/RadioButton.cpp (+1/-3)
Nux/RangeValue.cpp (+1/-1)
Nux/RangeValue.h (+1/-1)
Nux/RangeValueInteger.cpp (+1/-1)
Nux/RangeValueInteger.h (+1/-1)
Nux/ScrollView.cpp (+0/-2)
Nux/SpinBox_Logic.cpp (+2/-2)
Nux/SpinBox_Logic.h (+2/-2)
Nux/TabView.cpp (+3/-3)
Nux/TabView.h (+3/-3)
Nux/TextEntry.cpp (+6/-7)
Nux/TextEntry.h (+1/-1)
Nux/Theme.cpp (+1/-1)
Nux/VScrollBar.cpp (+4/-4)
Nux/VScrollBar.h (+4/-4)
Nux/VSplitter.cpp (+0/-19)
Nux/VSplitter.h (+1/-1)
Nux/View.cpp (+290/-36)
Nux/View.h (+22/-14)
Nux/WindowCompositor.cpp (+12/-12)
Nux/WindowCompositor.h (+0/-1)
Nux/WindowThread.cpp (+0/-1)
Nux/WindowThread.h (+0/-1)
NuxCore/Animation.cpp (+3/-2)
NuxCore/AnimationController.cpp (+1/-0)
NuxCore/AnimationController.h (+6/-1)
NuxCore/Color.cpp (+1/-1)
NuxCore/EasingCurve.cpp (+14/-0)
NuxCore/EasingCurve.h (+6/-0)
NuxGraphics/GLWindowManager.cpp (+2/-2)
NuxGraphics/GLWindowManager.h (+2/-2)
NuxGraphics/GpuDevice.cpp (+27/-4)
NuxGraphics/GpuDevice.h (+10/-1)
NuxGraphics/GpuDeviceTexture.cpp (+11/-0)
NuxGraphics/GraphicsDisplayWin.cpp (+233/-244)
NuxGraphics/GraphicsDisplayWin.h (+32/-37)
NuxGraphics/GraphicsDisplayX11.cpp (+54/-55)
NuxGraphics/GraphicsDisplayX11.h (+13/-15)
NuxGraphics/GraphicsEngine.cpp (+7/-0)
NuxGraphics/GraphicsEngine.h (+38/-2)
NuxGraphics/IOpenGLFrameBufferObject.cpp (+190/-90)
NuxGraphics/IOpenGLFrameBufferObject.h (+24/-9)
NuxGraphics/RenderingPipe.cpp (+32/-6)
NuxGraphics/RenderingPipeAsm.cpp (+120/-0)
NuxGraphics/RenderingPipeGLSL.cpp (+254/-18)
configure.ac (+2/-1)
api
lp:~unity-team/unity/unity.dash-to-preview
Neil J. Patel (community): Approve
Diff: 1553 lines (+738/-155)
23 files modified
dash/CoverflowResultView.cpp (+16/-2)
dash/DashView.cpp (+355/-17)
dash/DashView.h (+28/-1)
dash/FilterAllButton.cpp (+4/-0)
dash/FilterBar.cpp (+5/-10)
dash/FilterBasicButton.cpp (+21/-8)
dash/FilterBasicButton.h (+2/-0)
dash/FilterExpanderLabel.cpp (+48/-15)
dash/FilterMultiRangeButton.cpp (+7/-0)
dash/FilterRatingsButton.cpp (+7/-0)
dash/LensBar.cpp (+34/-17)
dash/LensBarIcon.cpp (+7/-7)
dash/LensView.cpp (+1/-2)
dash/PlacesGroup.cpp (+25/-36)
dash/ResultViewGrid.cpp (+36/-2)
dash/previews/PreviewContainer.cpp (+2/-2)
manual-tests/DashToPreviewTransition.txt (+38/-0)
plugins/unityshell/src/unityshell.cpp (+15/-7)
plugins/unityshell/src/unityshell.h (+3/-3)
unity-shared/DashStyle.h (+2/-0)
unity-shared/PlacesVScrollBar.cpp (+16/-9)
unity-shared/SearchBar.cpp (+64/-15)
unity-shared/UBusMessages.h (+2/-2)
api
lp:~stolowski/unity-lens-applications/show-more-apps-on-no-query
Neil J. Patel (community): Approve
Diff: 508 lines (+275/-24)
8 files modified
src/Makefile.am (+1/-0)
src/daemon.vala (+108/-23)
src/runner.vala (+1/-1)
src/software-center-data-cache.vala (+71/-0)
src/software-center-data-provider.vala (+20/-0)
src/unity-package-search.cc (+62/-0)
src/unity-package-search.h (+9/-0)
vapi/unity-package-search.vapi (+3/-0)
api
lp:~stolowski/unity-lens-applications/no-uninstall-for-ubuntu-desktop
Neil J. Patel (community): Approve
Diff: 38 lines (+8/-3)
2 files modified
src/daemon.vala (+6/-3)
src/software-center-data-provider.vala (+2/-0)
api
lp:~timo-jyrinki/ubuntu/quantal/unity-scope-video-remote/ubuntu.0310_11
Sebastien Bacher: Approve
Ubuntu branches: Pending requested
Diff: 36 lines (+10/-1)
2 files modified
debian/changelog (+7/-0)
src/unity-scope-video-remote (+3/-1)
api
lp:~mhr3/unity-lens-music/increased-u1-results-size
Paweł Stołowski (community): Approve
Diff: 11 lines (+1/-0)
1 file modified
src/musicstore-collection.vala (+1/-0)
api
lp:~nick-dedekind/unity/dash-results.focus+size
Andrea Azzarone (community): Needs Fixing
John Lea (community): Approve (design)
Michal Hruby (community): Approve
Diff: 356 lines (+56/-128)
4 files modified
dash/ResultRendererTile.cpp (+34/-120)
dash/ResultRendererTile.h (+0/-4)
unity-shared/DashStyle.cpp (+18/-3)
unity-shared/DashStyle.h (+4/-1)
api
lp:~nick-dedekind/unity/fix-music-preview-scroll
Neil J. Patel (community): Approve
Diff: 16 lines (+3/-3)
1 file modified
dash/previews/Track.cpp (+3/-3)
api
lp:~nick-dedekind/unity/preview-button-navigation
Michal Hruby (community): Approve
John Lea (community): Approve (design)
Diff: 592 lines (+254/-98)
8 files modified
dash/DashView.cpp (+6/-3)
dash/previews/ActionButton.cpp (+3/-30)
dash/previews/ActionButton.h (+5/-3)
dash/previews/Preview.cpp (+166/-6)
dash/previews/Preview.h (+8/-1)
dash/previews/PreviewContainer.cpp (+61/-55)
dash/previews/PreviewContainer.h (+3/-0)
dash/previews/PreviewNavigator.h (+2/-0)
api
lp:~nick-dedekind/unity/preview-content-background-shadows
Brandon Schaefer (community): Approve
Diff: 226 lines (+41/-17)
7 files modified
dash/previews/ApplicationPreview.cpp (+7/-4)
dash/previews/GenericPreview.cpp (+7/-3)
dash/previews/MoviePreview.cpp (+7/-3)
dash/previews/MusicPreview.cpp (+7/-3)
unity-shared/CoverArt.cpp (+7/-3)
unity-shared/PreviewStyle.cpp (+4/-1)
unity-shared/PreviewStyle.h (+2/-0)
api
lp:~nick-dedekind/unity/preview-navigation-button-opacity
Michal Hruby (community): Approve
John Lea (community): Approve (design)
Diff: 117 lines (+51/-2)
4 files modified
dash/previews/PreviewContainer.cpp (+1/-0)
dash/previews/PreviewNavigator.cpp (+37/-1)
dash/previews/PreviewNavigator.h (+12/-0)
unity-shared/IconTexture.cpp (+1/-1)
api
lp:~nick-dedekind/unity/lp857422.dash-mouse-steal
Brandon Schaefer (community): Approve
Diff: 948 lines (+329/-111)
17 files modified
dash/DashController.cpp (+30/-13)
dash/DashController.h (+4/-5)
dash/DashView.cpp (+5/-0)
dash/DashView.h (+2/-0)
hud/HudAbstractView.h (+3/-1)
hud/HudController.cpp (+42/-11)
hud/HudController.h (+7/-3)
hud/HudView.cpp (+60/-65)
hud/HudView.h (+4/-5)
hud/StandaloneHud.cpp (+1/-4)
plugins/unityshell/src/unityshell.cpp (+45/-3)
plugins/unityshell/src/unityshell.h (+2/-0)
tests/autopilot/unity/emulators/dash.py (+4/-0)
tests/autopilot/unity/tests/test_dash.py (+33/-0)
tests/autopilot/unity/tests/test_hud.py (+32/-0)
tests/test_hud_controller.cpp (+2/-1)
unity-shared/ResizingBaseWindow.h (+53/-0)
api
lp:~nick-dedekind/unity/preview-action-extra-text
Michal Hruby (community): Approve
Diff: 550 lines (+190/-17)
10 files modified
dash/previews/ActionButton.cpp (+47/-4)
dash/previews/ActionButton.h (+8/-1)
dash/previews/Preview.cpp (+5/-1)
dash/previews/StandaloneApplicationPreview.cpp (+18/-7)
tests/test_previews_application.cpp (+25/-1)
tests/test_previews_generic.cpp (+25/-1)
tests/test_previews_movie.cpp (+25/-1)
tests/test_previews_music.cpp (+25/-1)
unity-shared/PreviewStyle.cpp (+9/-0)
unity-shared/PreviewStyle.h (+3/-0)
api
lp:~nick-dedekind/unity/lp923657.dash-dismiss
Brandon Schaefer (community): Approve
Christopher Lee (community): Needs Fixing
Andrea Azzarone (community): Needs Fixing
Diff: 367 lines (+144/-50)
8 files modified
dash/DashController.cpp (+8/-10)
dash/DashController.h (+2/-1)
launcher/LauncherController.cpp (+1/-1)
manual-tests/Dash.txt (+13/-0)
plugins/unityshell/src/unityshell.cpp (+13/-4)
plugins/unityshell/src/unityshell.h (+1/-1)
tests/autopilot/unity/tests/test_dash.py (+55/-17)
tests/autopilot/unity/tests/test_hud.py (+51/-16)
api
lp:~stolowski/unity-lens-music/price-as-extra-text
Michal Hruby (community): Approve
Diff: 58 lines (+14/-1)
4 files modified
src/album.vala (+1/-0)
src/musicstore-collection.vala (+10/-0)
src/musicstore-scope.vala (+2/-0)
tests/manual/previews-musicstore.txt (+1/-1)
api
lp:~stolowski/unity-lens-music/missing-cover-icon
Michal Hruby (community): Needs Fixing
Diff: 215 lines (+47/-35)
5 files modified
src/banshee-collection.vala (+5/-8)
src/banshee-scope.vala (+8/-7)
src/musicstore-scope.vala (+2/-1)
src/rhythmbox-collection.vala (+19/-10)
src/rhythmbox-scope.vala (+13/-9)
api
lp:~stolowski/unity/missing-music-video-icons
Neil J. Patel: Pending requested
Diff: 6 lines (+0/-0)
0 files modified
api
Michal Hruby (community): Approve
Diff: 6 lines (+0/-0)
0 files modified
api
lp:~stolowski/unity-lens-applications/use-raw-price
Michal Hruby (community): Approve
Diff: 32 lines (+3/-1)
2 files modified
src/daemon.vala (+1/-1)
src/software-center-data-provider.vala (+2/-0)
api
lp:~nicolas-doffay/unity/coverflow-mouse-select-fix
Neil J. Patel (community): Approve
Diff: 19 lines (+5/-3)
1 file modified
dash/CoverflowResultView.cpp (+5/-3)
api
lp:~mhr3/unity/icon-loader-width-and-height
Omer Akram (community): Approve
John Lea (community): Approve (design)
Nick Dedekind (community): Approve
Diff: 1235 lines (+416/-178)
15 files modified
dash/ResultRendererTile.cpp (+11/-17)
dash/ResultRendererTile.h (+1/-1)
launcher/DeviceNotificationDisplayImp.cpp (+4/-3)
plugins/unityshell/resources/emblem_apps.svg (+19/-0)
plugins/unityshell/resources/emblem_books.svg (+9/-0)
plugins/unityshell/resources/emblem_clothes.svg (+8/-0)
plugins/unityshell/resources/emblem_music.svg (+15/-0)
plugins/unityshell/resources/emblem_video.svg (+17/-0)
tests/test_icon_loader.cpp (+6/-6)
unity-shared/CoverArt.cpp (+16/-10)
unity-shared/CoverArt.h (+3/-3)
unity-shared/IconLoader.cpp (+290/-127)
unity-shared/IconLoader.h (+9/-5)
unity-shared/IconTexture.cpp (+7/-5)
unity-shared/IconTexture.h (+1/-1)
api
lp:~unity-team/unity/match-designed-sizings
Andrea Azzarone (community): Approve
Xi Zhu (community): Approve (design)
John Lea: Pending (design) requested
Diff: 251 lines (+62/-61)
11 files modified
dash/LensBar.cpp (+3/-1)
dash/PlacesGroup.cpp (+4/-3)
dash/previews/ActionButton.cpp (+1/-1)
plugins/unityshell/resources/lens-nav-app.svg (+12/-12)
plugins/unityshell/resources/lens-nav-file.svg (+3/-8)
plugins/unityshell/resources/lens-nav-gwibber.svg (+14/-0)
plugins/unityshell/resources/lens-nav-home.svg (+4/-4)
plugins/unityshell/resources/lens-nav-music.svg (+6/-11)
plugins/unityshell/resources/lens-nav-photo.svg (+6/-11)
plugins/unityshell/resources/lens-nav-video.svg (+8/-9)
unity-shared/PreviewStyle.cpp (+1/-1)
api
lp:~nicolas-doffay/unity/preview-click-exit
Neil J. Patel (community): Approve
Nick Dedekind: Pending requested
Diff: 116 lines (+33/-4)
6 files modified
dash/CoverflowResultView.cpp (+5/-3)
dash/previews/MusicPreview.cpp (+1/-0)
dash/previews/Preview.cpp (+8/-0)
dash/previews/Preview.h (+2/-0)
dash/previews/PreviewContainer.cpp (+15/-0)
dash/previews/PreviewContainer.h (+2/-1)
api
John Lea (johnlea)
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → Critical
status: New → Triaged
Changed in unity:
status: New → Triaged
Changed in unity (Ubuntu):
status: New → Triaged
Changed in ayatana-design:
status: Triaged → Fix Committed
tags: added: dashm udp
Changed in unity:
milestone: none → backlog
importance: Undecided → Critical
Changed in unity (Ubuntu):
importance: Undecided → Critical
Tim Penhey (thumper)
Changed in unity:
milestone: backlog → none
Tim Penhey (thumper)
tags: added: exbacklog
Timo Jyrinki (timo-jyrinki)
description: updated
Revision history for this message
Iain Lane (laney) wrote :

Can we have some more information about what changes you're making?

You'll be asking the doc team to retake their screenshots of the dash for this feature, so please consider again whether they are all crucial to include in 12.10, given where we are in the release cycle, then reply with information so that we can be better informed about what's being requested here.

Is there any chance of regressions? If so, what's the plan to deal with them?

When will you be able to land this, if approved?

Revision history for this message
Iain Lane (laney) wrote :

I'm setting this to Incomplete, but please reset to New once you've supplied the information asked for. Thanks!

Changed in unity (Ubuntu):
status: Triaged → Incomplete
Changed in unity-lens-music (Ubuntu):
status: New → Incomplete
Changed in unity-lens-photos (Ubuntu):
status: New → Incomplete
Revision history for this message
David Callé (davidc3) wrote :

For unity-lens-photos: icon path changes.
It's not affecting the interface, as similar icons were provided by the lens package itself, the lens now depends on Unity for them.

Changed in unity-lens-photos (Ubuntu):
status: Incomplete → New
Revision history for this message
Iain Lane (laney) wrote :

photos> Is it already in the current Unity in Quantal? Don't forget to update the packaging to have the correctly versioned Depends.

Revision history for this message
Iain Lane (laney) wrote :

17/09 17:28:41 <Laney> davidcalle: you said it depends on some change in Unity
17/09 17:28:51 <Laney> I want to know if that change is already in or if it's in a future Unity version
17/09 17:29:55 <davidcalle> Laney, the changes are in the Unity branches linked to the report, so not yet in Quantal.

So this depends on the rest of this FFe.

John Lea (johnlea)
description: updated
Revision history for this message
Neil J. Patel (njpatel) wrote :

Moving back to triaged as John updated the description with the changes as requested.

Changed in unity (Ubuntu):
status: Incomplete → Triaged
Changed in unity-lens-music (Ubuntu):
status: Incomplete → Triaged
Neil J. Patel (njpatel)
Changed in unity (Ubuntu):
status: Triaged → New
Changed in unity-lens-music (Ubuntu):
status: Triaged → New
John Lea (johnlea)
Changed in unity-lens-music (Ubuntu):
importance: Undecided → Critical
Changed in unity-lens-photos (Ubuntu):
importance: Undecided → Critical
Changed in unity-lens-music:
importance: Undecided → Critical
Kate Stewart (kate.stewart)
Changed in unity (Ubuntu):
milestone: none → ubuntu-12.10-beta-2
Changed in unity-lens-music (Ubuntu):
milestone: none → ubuntu-12.10-beta-2
Changed in unity-lens-photos (Ubuntu):
milestone: none → ubuntu-12.10-beta-2
Neil J. Patel (njpatel)
description: updated
Revision history for this message
Neil J. Patel (njpatel) wrote :

Doc team and Translation team notifications by John Lea:

https://lists.ubuntu.com/archives/ubuntu-doc/2012-September/016861.html
https://lists.ubuntu.com/archives/ubuntu-translators/2012-September/005590.html

Jeremy's reply is correct, this sprint was at a bad time and we were hit by the gsettings etc bits slowing down the landing of the previews. We'll fix this for 13.04 and have the sprint much earlier, sorry for the extra work at this time to both docs and translations team.

Changed in unity:
milestone: none → 6.6
Daniel van Vugt (vanvugt)
Changed in unity:
milestone: 6.6 → 7.0
status: Triaged → Fix Committed
Revision history for this message
John Lea (johnlea) wrote :

Matt Price (the lead copywriter at Canonical) has agreed to update the documentation with the latest Dash changes. A member of the documentation team will need to contact him to show him where the documentation lives andbrief him on the process for contributing to the documentation.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

-1 from Docs for the reasons I stated at https://lists.ubuntu.com/archives/ubuntu-doc/2012-September/016862.html

I don't think that the Docs Team or the Release Team really have the time to evaluate 24 additional UI freeze exception items the day before DocumentationStringFreeze, Beta2Freeze, and 3 weeks after UI Freeze. A lot of our documentation work cannot start until the UI stops changing, and having the UI stop changing on the day that we have to stop writing docs puts us in an impossible situation.

I did talk with Matt and look forward to working with him in the future when we have more time available.

Revision history for this message
Kate Stewart (kate.stewart) wrote :

Have been in discussion with jbicha and dpm, plan agreed to is:
- Documentation String Freeze is going to move to 9/28 (Tuesday)
- Matt Price is going to help write the text to describe the new features, and docs team will edit into right places.
- David Planella will be sending out email summary to translation team summarizing areas NOT to focus on until after the new docs string freeze date.

Based on discussion with Laney, Didier, Neil, Alan, Olli plan is:
- Land this in PPA today, Alan's team testing today/tomorrow and providing feedback prior to upload.
- Neil has checked that all of the branches with "Needs fixing" have in fact been resolved.
- If no blockers found during testing, this will be uploaded to archive for beta 2 freeze.
- If significant issues found after upload, feature specific reversion will be done.
- Post mortem will be held to make sure this sort of situation does not reoccur in future.

Approved, subject to no significant issues being found in testing and it can land by beta 2 freeze.

Changed in unity (Ubuntu):
status: New → Triaged
Changed in unity-lens-music (Ubuntu):
status: New → Triaged
Changed in unity-lens-photos (Ubuntu):
status: New → Triaged
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Yes, +1 from the Docs Team if this can land by Beta2Freeze and we'll wrap up the screenshots this weekend.

Omer Akram (om26er)
no longer affects: unity/6.0
Changed in unity:
milestone: 7.0 → 6.6
Neil J. Patel (njpatel)
description: updated
Revision history for this message

Al 18/09/12 19:12, En/na John Lea ha escrit:
> Hi Documentation and Translation teams,
>
> We are currently in the process of finally landing the Dash work from
> this cycle. I know this is very late, but we are now making the final
> push to get everything landed into 12.10. The new 12.10 Dash will
> update some aspects of the overall Dash appearance.
>
> Ideally great if we could take new screenshots of the Dash and do a
> translation review of these changes when Beta2 arrives. However even if
> if is not possible to take new screenshots the structure of the Dash and
> the copy is broadly similar to the current Dash, so even if it is not
> possible to update the screenshots there should still not be any major
> issues.
>
> The bug that is landing these changes is
> https://bugs.launchpad.net/ayatana-design/+bug/1049593
>
> Apologies again for how late this is landing in the cycle, and thanks
> for your understanding.
>
> cheers,
> John
>

After a chat with Neil, the impact for translators will be just the
addition of the "More suggestions" string, which I think is ok in terms
of translations, considering the amount of changes. So +1 from translations.

I fully agree with Jeremy on his reply, though, in that these changes
should a) be properly be communicated in advance and b) land much
earlier in the cycle.

Working at Canonical myself, I have full understanding for everyone
working hard to meet the deadlines and provide the best OS experience
with the best features to our users. But in line with our philosophy and
our values, we should also make an additional effort to have plans in
place to avoid or mitigate any extra work from our awesome and dedicated
volunteer contributors.

Cheers,
David.

--
David Planella
Ubuntu Translations Coordinator
www.ubuntu.com / www.davidplanella.wordpress.com
www.identi.ca/dplanella / www.twitter.com/dplanella

Didier Roche-Tolomelli (didrocks)
Changed in unity (Ubuntu):
status: Triaged → Fix Released
Changed in unity-lens-music (Ubuntu):
status: Triaged → Fix Released
Changed in unity-lens-photos (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-asset-pool - 0.8.24-0ubuntu2

---------------
unity-asset-pool (0.8.24-0ubuntu2) quantal-proposed; urgency=low

* New upstream release:
- [FFE][UIFE]Dash - Finesse the placement, movement and behaviour
of the 12.10 Dash (LP: #1049593)
-- Didier Roche <email address hidden> 2012年9月20日 20:45:29 +0200

Changed in unity-asset-pool (Ubuntu):
status: New → Fix Released
Daniel van Vugt (vanvugt)
Changed in unity:
status: Fix Committed → Fix Released
Timo Jyrinki (timo-jyrinki)
Changed in unity-lens-music:
status: New → Fix Released
Changed in unity-lens-photos:
status: New → Fix Released
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
tags: added: reviewedbydesignq
removed: udp
To post a comment you must log in.
This report contains Public information
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

AltStyle によって変換されたページ (->オリジナル) /