Reading serial buffer taking newline character instead of user input

Question

I am trying to compare whether the user input matches a user ID or not. When I read the input from serial, the program is taking the last character which is newline char '\n' and moving it into the char data value to compare against the stored user ID and I don't understand why it's taking the '\n' value instead of the actual user input.

int Gled = 7;
int Rled = 8;
int wait = 5000;
char UserID = "12345";
char data;
char incoming;
void setup() {
 Serial.begin(9600);
 pinMode(Gled,OUTPUT);
 pinMode(Rled,OUTPUT);
 Serial.println("Please Enter your username or ID:");
}
void loop() {
 if(Serial.available()>0) {
 while(1) {
 data=Serial.read(); //read user input and move to data char
 if(data !='\n')
 incoming = data; //if data doesn't equal newline data = incoming
 if (data == '\n')
 break; // newline char detected break
 if (data == -1) //continue reading all of user input
 continue;
 Serial.print(data);
 Serial.print(incoming);
 }
 Serial.println(incoming);
 if(incoming == UserID) { //if user input matches run statement
 digitalWrite(Gled, HIGH);
 Serial.println();
 Serial.println("Access Granted");
 Serial.println("Hello User Name");
 delay(wait);
 Serial.println("Login time exceeded, you are now logged out.");
 Serial.println("Reenter your UserID to log back in.");
 digitalWrite(Gled, LOW);
 Serial.end();
 Serial.begin(9600);
 } else if(incoming != UserID){
 //user input doesn't match run statement
 digitalWrite(Rled, HIGH);
 Serial.println();
 Serial.println("Access Denied");
 Serial.end();
 delay(wait);
 Serial.begin(9600);
 digitalWrite(Rled, LOW);
 Serial.println("Please Enter a Valid ID to Continue.");
 }
 }
}

• Majenko: Your whole data reading and user ID storage and comparison is completely wrong.
• Majenko: Read this: hackingmajenkoblog.wordpress.com/2016/02/01/…
• Majenko: Some parts of this can help too: hackingmajenkoblog.wordpress.com/2016/02/04/…
• 1fastk: Thanks for those links, I read them and figured out what I was doing wrong.

Answer 1

if(data !='n')

This should be

if(data !='\n')

NEXT.

data=Serial.read();

only reads ONE character. You should add to a buffer, not assign a single character.

• 1fastk: Thats my mistake for leaving that in there I had already copied the text before fixing that typo but the program still has the same issue.