Table::getDisplayLines() should not output excessive lines when no rows #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

slaFFik wants to merge 3 commits into wp-cli:main

from slaFFik:patch-2

Open

Table::getDisplayLines() should not output excessive lines when no rows #165

slaFFik wants to merge 3 commits into wp-cli:main from slaFFik:patch-2

Conversation

@slaFFik

Copy link

Contributor

@slaFFik slaFFik commented Sep 28, 2023

Fix #164.

@slaFFik


 Table::getDisplayLines() should not output excessive lines

4d4b774

Fix wp-cli#164.

@slaFFik slaFFik requested a review from a team as a code owner

September 28, 2023 21:10

@slaFFik slaFFik changed the title ~~(削除) Table::getDisplayLines() should not output excessive lines (削除ここまで)~~ (追記) Table::getDisplayLines() should not output excessive lines when no rows (追記ここまで)

Sep 28, 2023

danielbachhuber

danielbachhuber reviewed

Sep 29, 2023

View reviewed changes

Copy link

Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the tests are addressed accordingly?

@slaFFik

Copy link

Contributor Author

slaFFik commented Sep 29, 2023

Yes, sure, I will try to do that today/tomorrow.
Sorry for missing them (was in jeopardy when creating this PR and forgot to check the checks' status, my bad).