Pinging maintainers to get eyes on this @swissspidy @danielbachhuber @schlessera

Note that we get pinged automatically with the review request :)

Two thoughts:

1. Network meta command accessing the incorrect caches #504 mentions steps to reproduce the issue — this could be added as a Behat test.
2. Looking at https://core.trac.wordpress.org/ticket/61467, it sounds like this could just as well be fixed only in core — so why this change here? Could we just wait for the core fix?

Note that we get pinged automatically with the review request :)

No one was assigned for a code reviewers. Maybe this repo needs a codeowner file 🤔

#504 mentions steps to reproduce the issue — this could be added as a Behat test.

Before spending any time on getting tests to work, I wanted to make sure everyone was happy with the approach.

Looking at https://core.trac.wordpress.org/ticket/61467, it sounds like this could just as well be fixed only in core — so why this change here? Could we just wait for the core fix?

The core patch is not confirmed yet and not work. Also that will only fix the issue with 6.8+. WP CLI support down to 3.7. Fixing this here is to ensure BC.

No one was assigned for a code reviewers.

Screenshot 2025年01月22日 at 14 51 12
Screenshot 2025年01月22日 at 14 51 05

Before spending any time on getting tests to work, I wanted to make sure everyone was happy with the approach.

It looks reasonable to me in theory, yes.

No one was assigned for a code reviewers.

This is what I see

Yes, approach looks good, @jonnynews. If we add the tests from #504 , this will be good to go.

According to the issue description, the following test should reproduce the situation:

 Scenario: Network meta is actually network options
 Given a WP multisite install
 When I run `wp eval 'update_network_option( 1, "mykey", "123" );'`
 And I run `wp eval 'echo get_network_option( 1, "mykey" );'`
 Then STDOUT should be:
 """
 123
 """
 When I run `wp network meta update 1 mykey 456`
 Then STDOUT should be:
 """
 Success: Updated custom field 'mykey'.
 """
 When I run `wp network meta get 1 mykey`
 Then STDOUT should be:
 """
 456
 """
 When I run `wp eval 'echo get_network_option( 1, "mykey" );'`
 Then STDOUT should be:
 """
 456
 """

Is that accurate?

Because this currently passes for me on main... 🤔