-
-
Notifications
You must be signed in to change notification settings - Fork 959
fix(helm): support secrets.existingSecret for core secrets #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
138 changes: 138 additions & 0 deletions
.github/workflows/helm-pr-prerelease.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| name: 🧭 Helm Chart PR Prerelease | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| paths: | ||
| - "hosting/k8s/helm/**" | ||
|
|
||
| concurrency: | ||
| group: helm-prerelease-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| REGISTRY: ghcr.io | ||
| CHART_NAME: trigger | ||
|
|
||
| jobs: | ||
| lint-and-test: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Helm | ||
| uses: azure/setup-helm@v4 | ||
| with: | ||
| version: "3.18.3" | ||
|
|
||
| - name: Build dependencies | ||
| run: helm dependency build ./hosting/k8s/helm/ | ||
|
|
||
| - name: Extract dependency charts | ||
| run: | | ||
| cd ./hosting/k8s/helm/ | ||
| for file in ./charts/*.tgz; do echo "Extracting $file"; tar -xzf "$file" -C ./charts; done | ||
nicktrn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: Lint Helm Chart | ||
| run: | | ||
| helm lint ./hosting/k8s/helm/ | ||
|
|
||
| - name: Render templates | ||
| run: | | ||
| helm template test-release ./hosting/k8s/helm/ \ | ||
| --values ./hosting/k8s/helm/values.yaml \ | ||
| --output-dir ./helm-output | ||
|
|
||
| - name: Validate manifests | ||
| uses: docker://ghcr.io/yannh/kubeconform:v0.7.0 | ||
| with: | ||
| entrypoint: "/kubeconform" | ||
| args: "-summary -output json ./helm-output" | ||
|
|
||
| prerelease: | ||
| needs: lint-and-test | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| pull-requests: write | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Helm | ||
| uses: azure/setup-helm@v4 | ||
| with: | ||
| version: "3.18.3" | ||
|
|
||
| - name: Build dependencies | ||
| run: helm dependency build ./hosting/k8s/helm/ | ||
|
|
||
| - name: Extract dependency charts | ||
| run: | | ||
| cd ./hosting/k8s/helm/ | ||
| for file in ./charts/*.tgz; do echo "Extracting $file"; tar -xzf "$file" -C ./charts; done | ||
|
|
||
| - name: Log in to Container Registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Generate prerelease version | ||
| id: version | ||
| run: | | ||
| BASE_VERSION=$(grep '^version:' ./hosting/k8s/helm/Chart.yaml | awk '{print 2ドル}') | ||
| PR_NUMBER=${{ github.event.pull_request.number }} | ||
| SHORT_SHA=$(echo "${{ github.event.pull_request.head.sha }}" | cut -c1-7) | ||
| PRERELEASE_VERSION="${BASE_VERSION}-pr${PR_NUMBER}.${SHORT_SHA}" | ||
| echo "version=$PRERELEASE_VERSION" >> $GITHUB_OUTPUT | ||
| echo "Prerelease version: $PRERELEASE_VERSION" | ||
|
|
||
| - name: Update Chart.yaml with prerelease version | ||
| run: | | ||
| sed -i "s/^version:.*/version: ${{ steps.version.outputs.version }}/" ./hosting/k8s/helm/Chart.yaml | ||
|
|
||
| - name: Package Helm Chart | ||
| run: | | ||
| helm package ./hosting/k8s/helm/ --destination /tmp/ | ||
|
|
||
| - name: Push Helm Chart to GHCR | ||
| run: | | ||
| VERSION="${{ steps.version.outputs.version }}" | ||
| CHART_PACKAGE="/tmp/${{ env.CHART_NAME }}-${VERSION}.tgz" | ||
|
|
||
| # Push to GHCR OCI registry | ||
| helm push "$CHART_PACKAGE" "oci://${{ env.REGISTRY }}/${{ github.repository_owner }}/charts" | ||
|
|
||
| - name: Find existing comment | ||
| uses: peter-evans/find-comment@v3 | ||
| id: find-comment | ||
| with: | ||
| issue-number: ${{ github.event.pull_request.number }} | ||
| comment-author: "github-actions[bot]" | ||
| body-includes: "Helm Chart Prerelease Published" | ||
|
|
||
| - name: Create or update PR comment | ||
| uses: peter-evans/create-or-update-comment@v4 | ||
| with: | ||
| comment-id: ${{ steps.find-comment.outputs.comment-id }} | ||
| issue-number: ${{ github.event.pull_request.number }} | ||
| body: | | ||
| ### 🧭 Helm Chart Prerelease Published | ||
|
|
||
| **Version:** `${{ steps.version.outputs.version }}` | ||
|
|
||
| **Install:** | ||
| ```bash | ||
| helm upgrade --install trigger \ | ||
| oci://ghcr.io/${{ github.repository_owner }}/charts/trigger \ | ||
| --version "${{ steps.version.outputs.version }}" | ||
| ``` | ||
|
|
||
| > ⚠️ This is a prerelease for testing. Do not use in production. | ||
| edit-mode: replace | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.