apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.deployments.$deploymentParam/route.tsx (1)

85-167: Consider refactoring to a lookup object for better maintainability.

The getTriggeredViaDisplay function works correctly and handles all edge cases well, including graceful fallbacks for unknown values. However, the large switch statement could be refactored to use a lookup object for improved maintainability.

♻️ Optional refactor using a lookup object

+const TRIGGERED_VIA_DISPLAY_MAP: Record<
+ string,
+ { icon: React.ComponentType<{ className?: string }>; label: string }
+> = {
+ "cli:manual": { icon: TerminalSquareIcon, label: "CLI (Manual)" },
+ "cli:github_actions": { icon: GitBranchIcon, label: "CLI (GitHub Actions)" },
+ "cli:gitlab_ci": { icon: ServerIcon, label: "CLI (GitLab CI)" },
+ "cli:circleci": { icon: ServerIcon, label: "CLI (CircleCI)" },
+ "cli:jenkins": { icon: ServerIcon, label: "CLI (Jenkins)" },
+ "cli:azure_pipelines": { icon: ServerIcon, label: "CLI (Azure Pipelines)" },
+ "cli:bitbucket_pipelines": { icon: ServerIcon, label: "CLI (Bitbucket Pipelines)" },
+ "cli:travis_ci": { icon: ServerIcon, label: "CLI (Travis CI)" },
+ "cli:buildkite": { icon: ServerIcon, label: "CLI (Buildkite)" },
+ "cli:ci_other": { icon: ServerIcon, label: "CLI (CI)" },
+ "git_integration:github": { icon: GitBranchIcon, label: "GitHub Integration" },
+ dashboard: { icon: LayoutDashboardIcon, label: "Dashboard" },
+};
+
 function getTriggeredViaDisplay(triggeredVia: string | null | undefined): {
 icon: React.ReactNode;
 label: string;
 } | null {
 if (!triggeredVia) return null;
 const iconClass = "size-4 text-text-dimmed";
-
- switch (triggeredVia) {
- case "cli:manual":
- return {
- icon: <TerminalSquareIcon className={iconClass} />,
- label: "CLI (Manual)",
- };
- case "cli:github_actions":
- return {
- icon: <GitBranchIcon className={iconClass} />,
- label: "CLI (GitHub Actions)",
- };
- case "cli:gitlab_ci":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (GitLab CI)",
- };
- case "cli:circleci":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (CircleCI)",
- };
- case "cli:jenkins":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (Jenkins)",
- };
- case "cli:azure_pipelines":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (Azure Pipelines)",
- };
- case "cli:bitbucket_pipelines":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (Bitbucket Pipelines)",
- };
- case "cli:travis_ci":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (Travis CI)",
- };
- case "cli:buildkite":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (Buildkite)",
- };
- case "cli:ci_other":
- return {
- icon: <ServerIcon className={iconClass} />,
- label: "CLI (CI)",
- };
- case "git_integration:github":
- return {
- icon: <GitBranchIcon className={iconClass} />,
- label: "GitHub Integration",
- };
- case "dashboard":
- return {
- icon: <LayoutDashboardIcon className={iconClass} />,
- label: "Dashboard",
- };
- default:
- // Handle any unknown values gracefully
- if (triggeredVia.startsWith("cli:")) {
- return {
- icon: <TerminalSquareIcon className={iconClass} />,
- label: `CLI (${triggeredVia.replace("cli:", "")})`,
- };
- }
- return {
- icon: <ServerIcon className={iconClass} />,
- label: triggeredVia,
- };
- }
+ 
+ const config = TRIGGERED_VIA_DISPLAY_MAP[triggeredVia];
+ 
+ if (config) {
+ const IconComponent = config.icon;
+ return {
+ icon: <IconComponent className={iconClass} />,
+ label: config.label,
+ };
+ }
+ 
+ // Handle any unknown values gracefully
+ if (triggeredVia.startsWith("cli:")) {
+ return {
+ icon: <TerminalSquareIcon className={iconClass} />,
+ label: `CLI (${triggeredVia.replace("cli:", "")})`,
+ };
+ }
+ 
+ return {
+ icon: <ServerIcon className={iconClass} />,
+ label: triggeredVia,
+ };
 }

This approach makes it easier to add or modify trigger source mappings without touching the function logic.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025年11月27日T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Use build extensions in trigger.config.ts (additionalFiles, additionalPackages, aptGet, prismaExtension, etc.) to customize the build

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025年11月27日T16:26:58.661Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : Follow the Remix 2.1.0 and Express server conventions when updating the main trigger.dev webapp

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025年11月27日T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Configure build process in trigger.config.ts using `build` object with external packages, extensions, and JSX settings

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025年11月27日T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Attach metadata to task runs using the metadata option when triggering, and access/update it inside runs using metadata functions

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025年11月27日T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use metadata methods (set, del, replace, append, remove, increment, decrement, stream, flush) to update metadata during task execution

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025年11月27日T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `trigger.dev/sdk/v3` for all imports in Trigger.dev tasks

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025年11月27日T16:26:58.661Z
Learning: Applies to apps/webapp/**/*.{ts,tsx} : When importing from `trigger.dev/core` in the webapp, use subpath exports from the package.json instead of importing from the root path

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025年11月27日T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Export tasks with unique IDs within the project to enable proper task discovery and execution

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2025年11月27日T16:26:58.661Z
Learning: Applies to apps/webapp/app/**/*.{ts,tsx} : Access all environment variables through the `env` export of `env.server.ts` instead of directly accessing `process.env` in the Trigger.dev webapp