fix: add workbook and view setter for custom view #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bcantoni merged 2 commits into tableau:development from jorwoods:jorwoods/custom_view_set_wb

Jan 6, 2026

Merged

fix: add workbook and view setter for custom view #1730

bcantoni merged 2 commits into tableau:development from jorwoods:jorwoods/custom_view_set_wb

Jan 6, 2026

Conversation

@jorwoods

Copy link

Contributor

@jorwoods jorwoods commented Dec 29, 2025

Closes #1729

Add setter methods for workbook and view properties.

@salesforce-cla salesforce-cla bot added the cla:signed label

Dec 29, 2025

@jorwoods


 fix: add workbook and view setter for custom view

eb2df3f

Closes tableau#1729
Add setter methods for workbook and view properties.

@jorwoods jorwoods force-pushed the jorwoods/custom_view_set_wb branch from 9a1de1e to eb2df3f Compare

December 29, 2025 14:48

@bcantoni

Copy link

Contributor

bcantoni commented Jan 6, 2026

@jorwoods this looks great. Should we also consider updating test_custom_view.py to replace those direct access _owner and _workbook with the new way? (I'm not sure that's super valuable though because we still have the direct access needed for _id.)