Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[6.x] Alert component #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayGeorge wants to merge 28 commits into master
base: master
Choose a base branch
Loading
from alert-component
Open

[6.x] Alert component #13599

JayGeorge wants to merge 28 commits into master from alert-component

Conversation

@JayGeorge
Copy link

@JayGeorge JayGeorge commented Jan 19, 2026 •
edited
Loading

Description of the Problem

Currently, there's no alert component

What this PR Does

2026年01月19日 at 16 29 49@2x

  • Adds an alert component
  • The alert component can be inline or a more detailed message
  • There are 4 variations
    • Default
    • Success
    • Error
    • Warning
  • Each variation defaults to a default icon but the user can also set a custom icon
  • The alert can also be used with heading/description components. This is documented and demo'd.

How to Reproduce

  1. It's easiest to check out cp/playground, where you'll find various alert demos, shown in the screenshot above.
  2. Alternatively, you can check out the commit Dashboard demo and go to cp/dashboard to see the component in situ.

@JayGeorge JayGeorge marked this pull request as draft January 21, 2026 15:56
@JayGeorge JayGeorge marked this pull request as ready for review January 21, 2026 17:18
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a heading prop. I thought that would be pretty useful so you dont need to start importing Heading and Description components manually.

I also made it so when you use the text prop, it'll put it into a Description component for consistency.

However I noticed it ends up with slightly different colors than when using just the span. Check it out. Here I've got both a Description and then the span just to illustrate it:

<Description :text="text" />
+<span v-html="text" />
CleanShot 2026年01月21日 at 14 48 25

Also, it messes with the padding/spacing:

<Alert text="This is a default alert message" />
<Alert><Description>This is a default alert message</Description></Alert>
CleanShot 2026年01月21日 at 14 51 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonvarga jasonvarga jasonvarga requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /