-
-
Notifications
You must be signed in to change notification settings - Fork 163
Investigate and fix random test failure #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lovasoa
wants to merge
1
commit into
main
from
cursor/investigate-and-fix-random-test-failure-gemini-3-pro-preview-fa5a
Draft
Investigate and fix random test failure #1128
lovasoa
wants to merge
1
commit into
main
from
cursor/investigate-and-fix-random-test-failure-gemini-3-pro-preview-fa5a
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: contact <contact@ophir.dev>
Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle database "table doesn't exist" errors in
FileSystemto prevent test failures due to race conditions and ensure fallback to embedded files.The
basic::test_index_oktest sometimes fails because it attempts to readindex.sqlfrom the database when thesqlpage_filestable has been concurrently dropped by another test. Previously, theFileCachewould receive a database error (e.g., "Table 'sqlpage.sqlpage_files' doesn't exist") and fail, instead of interpreting it as "file not found in database" and falling back to serving the embeddedindex.sqlfromstatic_files. This change explicitly catches these database errors and converts them into aNotFounderror, allowing the correct fallback mechanism to engage.