Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Investigate and fix random test failure #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lovasoa wants to merge 1 commit into main
base: main
Choose a base branch
Loading
from cursor/investigate-and-fix-random-test-failure-gemini-3-pro-preview-fa5a

Conversation

@lovasoa
Copy link
Collaborator

@lovasoa lovasoa commented Nov 24, 2025

Handle database "table doesn't exist" errors in FileSystem to prevent test failures due to race conditions and ensure fallback to embedded files.

The basic::test_index_ok test sometimes fails because it attempts to read index.sql from the database when the sqlpage_files table has been concurrently dropped by another test. Previously, the FileCache would receive a database error (e.g., "Table 'sqlpage.sqlpage_files' doesn't exist") and fail, instead of interpreting it as "file not found in database" and falling back to serving the embedded index.sql from static_files. This change explicitly catches these database errors and converts them into a NotFound error, allowing the correct fallback mechanism to engage.


Open in Cursor Open in Web

Copy link

cursor bot commented Nov 24, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /