-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Rework : solving problem of saving result of --sql-query in CSV file #5685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aridhi-Dhia-eddine
wants to merge
4
commits into
sqlmapproject:master
from
Aridhi-Dhia-eddine:my-sqlmap-contribution
Open
Rework : solving problem of saving result of --sql-query in CSV file #5685
Aridhi-Dhia-eddine
wants to merge
4
commits into
sqlmapproject:master
from
Aridhi-Dhia-eddine:my-sqlmap-contribution
+227
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Aridhi-Dhia-eddine
Copy link
@Aridhi-Dhia-eddine
Aridhi-Dhia-eddine
commented
Apr 12, 2024
- Rework: solve problem of saving result of --sql-query in CSV file #5679
@Imran-imtiaz48
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Analysis:
- Code Formatting and Structure:
o Both old and new code snippets appear identical in terms of functionality and structure. They iterate over temp_res and s lists to update a dictionary d and append it to dt_save. The subsequent conditional check for len(queryRes) also remains the same.
Improvement Suggestions: - Documentation and Comments:
o Consider adding comments or documentation within the code to clarify the purpose of each section (#*******************************************). This helps new developers understand the logic or intention behind that specific block of code. - Error Handling and Validation:
o Ensure that the conditional check if(len(queryRes)!=0): is accompanied by appropriate error handling or validation logic if queryRes could potentially be None or of unexpected length. Robust error handling improves code reliability. - Consistency and Best Practices:
o Review the entire codebase for consistency in variable naming (temp_res, s, d, dt_save, file_csv, queryRes, etc.) and adhere to best practices such as using meaningful variable names and following a consistent indentation style.
Conclusion:
The provided code snippets show consistency in functionality between the old and new versions. To enhance the GitHub repository, focus on improving documentation clarity, ensuring error handling, and maintaining code consistency. These practices contribute to better readability, maintainability, and reliability of the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.