Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: Add Dependabot #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjackman wants to merge 1 commit into rust-ndarray:master
base: master
Choose a base branch
Loading
from sjackman:sj/dependabot
Open

Conversation

@sjackman
Copy link

@sjackman sjackman commented Apr 10, 2025
edited
Loading

Enable Dependabot to open PRs to update dependencies.

Related PR

Enable [Dependabot](https://docs.github.com/en/code-security/dependabot) to open PRs to update dependencies.
Copy link
Collaborator

akern40 commented Apr 10, 2025

@sjackman would you mind making a related issue that explains what you see to be the benefits of Dependabot? I'm familiar with its security scanning, but I'm not sure what you mean by "open PRs to update dependencies".

Copy link
Author

I'm not sure what you mean by "open PRs to update dependencies".

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates

Keeping your dependencies updated automatically with Dependabot version updates
You can use Dependabot to automatically keep the dependencies and packages used in your repository updated to the latest version, even when they don’t have any known vulnerabilities.

Dependabot will open PRs against your repo to keep your dependencies up to date. See for example this PR that @dependabot opened in rust-bio to update petgraph:

Copy link
Collaborator

akern40 commented May 22, 2025

Thank you for bringing this to my attention! I've looked into this and learned a few things. First, that we do have Dependabot set up. Second, that I should be making sure to pay closer attention to it. And third, that Dependabot PRs would probably be more noise than signal. I say that because they take the approach of directly pinning the offending dependencies. But for ndarray, our security vulnerability alerts are a) mostly in dependencies of dependencies or b) in our workspace test crates, which I'm not sure that Dependabot will handle correctly.

My opinion here is that pinning every offending dependency directly in ndarray is a recipe for a laundry list of pins that aren't true dependencies. Personally, I think it would be much better for the downstream dependencies to do the pinning of their direct dependencies - as we should (and will) do for our direct dependencies.

Does this seem like a reasonable policy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /