Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Interrupt rescuing causes issues with debugger #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notEthan wants to merge 2 commits into ruby:master
base: master
Choose a base branch
Loading
from notEthan:rescue_noncritical_exceptions

Conversation

@notEthan
Copy link

@notEthan notEthan commented Jul 8, 2024
edited
Loading

The way Rake rescues exceptions running a task, I think, rescues too much. The problem I encounter is when I am using debug in a test task that runs in a subprocess (via Kernel#system) - raising an Interrupt with ctrl+c leaves the terminal in a state where it no longer echoes input.

To reproduce, with the debug gem installed and this Rakefile:

task(:default) { system("ruby -r debug -e debugger") }

Run rake; at the debug prompt hit ctrl+c. Your terminal no longer echoes your input; the tty is left in raw mode (I eventually found you can fix this by running stty -raw)

I think the solution to this is what RSpec does, rescuing broadly but with some exceptions to the Exceptions - see https://github.com/rspec/rspec-support/blob/v3.13.0/lib/rspec/support.rb#L145-L153

I've copied that in this PR and replaced every rescue Exception in lib/, though only lib/rake/application.rb affects my usage, I think it should be correct in the others as well.

@notEthan notEthan force-pushed the rescue_noncritical_exceptions branch from b33d4ed to d9af9b6 Compare October 24, 2025 19:07
@notEthan notEthan marked this pull request as ready for review October 24, 2025 19:08
Copy link
Author

I keep encountering this, changed draft PR to ready, hoping it looks acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /