Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Accept Pathname object as rule's prerequisite #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gemmaro wants to merge 2 commits into ruby:master
base: master
Choose a base branch
Loading
from gemmaro:feat/rule-pathname

Conversation

@gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Dec 15, 2023 •
edited
Loading

Hello,

This change allows the rule to accept a Pathname object as a prerequisite.

foo = Pathname("foo")
# before
rule ".o" => [".c", foo.to_s] do |t|
 # ...
end
# after
rule ".o" => ["c", foo] do |t|
 # ...
end

Thank you,

rgarner reacted with thumbs up emoji
@gemmaro gemmaro changed the title (削除) Accept Pathname-like object as rule's prerequisite (削除ここまで) (追記) Accept Pathname object as rule's prerequisite (追記ここまで) Dec 16, 2023
@gemmaro gemmaro force-pushed the feat/rule-pathname branch 2 times, most recently from a1df689 to 73ee66c Compare December 20, 2023 10:43
@hsbt hsbt force-pushed the feat/rule-pathname branch from 73ee66c to b9477ce Compare March 15, 2024 00:39
Copy link
Contributor Author

gemmaro commented Dec 29, 2024

I rebased to the latest master branch. Feel free to let me know if there is anything that needs to be done to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /