-
Notifications
You must be signed in to change notification settings - Fork 627
Limit calls to Dir.chdir in Rake::Application #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/rake/application.rb
Outdated
Comment on lines
277
to
278
Dir.chdir(dir) do
Dir.glob(@rakefiles.map { |name| escape_glob(name) }).first || @rakefiles.find(&:empty?)
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When support for Ruby < 2.5 is dropped, this Dir.chdir can be replaced with Dir.glob's base kwarg.
@jonathanhefner
jonathanhefner
force-pushed
the
limit-chdir-calls
branch
4 times, most recently
from
December 26, 2020 18:42
20a2140 to
856409f
Compare
This reduces "conflicting chdir during another chdir block" warnings when calling `Rake::Application#run` inside a `Dir.chdir` block.
@hsbt
hsbt
force-pushed
the
limit-chdir-calls
branch
from
March 25, 2022 10:00
856409f to
f34546f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This reduces "conflicting chdir during another chdir block" warnings when calling
Rake::Application#runinside aDir.chdirblock.