-
Notifications
You must be signed in to change notification settings - Fork 44
Update to ReScript 12 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why I added @rescript/runtime to the dependencies.
I think it is correct to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would making @rescript/runtime a peer dependency work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, the reason I want to be explicit with "@rescript/runtime" is that I see this popping up in isolated installs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rescript-lang/rescript#8196 brought me here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we no longer care about IE11?
@mediremi
mediremi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
cknitt
commented
Jan 20, 2026
I would also make @rescript/runtime a peer dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you use untagged variants here?
module FormData = { type t @unboxed type formValue = | String(string) | File(Js.File.t) @new external make: unit => t = "FormData" @send external append: (t, string, ~filename: string=?) => unit = "append" @send external delete: (t, string) => unit = "delete" @return(nullable) @send external get: (t, string) => option<formValue> = "get" @send external getAll: (t, string) => array<formValue> = "getAll" let getString = (formData, name) => { switch formData->get(name) { | Some(String(value)) => Some(value) | _ => None } } let getFile = (formData, name) => { switch formData->get(name) { | Some(File(value)) => Some(value) | _ => None } } @send external set: (string, string) => unit = "set" @send external has: string => bool = "has" // @send external keys: t => Iterator.t<string> = "keys"; // @send external values: t => Iterator.t<value> = "values"; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I do not care about the existing code. At lot of it can be improved, this is not what this PR is about.
I would like to start creating some alphas of a v12+ world