Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

RFC: Revamp TestUtils & tests #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bloodyowl wants to merge 3 commits into rescript-lang:master
base: master
Choose a base branch
Loading
from bloodyowl:revamp-tests

Conversation

@bloodyowl
Copy link
Contributor

@bloodyowl bloodyowl commented Mar 10, 2021 •
edited
Loading

Copy link

@JasoonS JasoonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me (although I have zero authority here...)

Copy link
Member

cknitt commented Sep 30, 2022

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

Copy link
Contributor

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

Not sure. Do they add value to justify the maintenance? E.g w.r.t. snapshot test where one just looks at the generated code?

Could go either way. No opinion.

Copy link
Member

mununki commented Oct 4, 2022

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

Copy link
Contributor

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

Checking in che compiled output seems by far the easiest thing. And tells everything there is to know.

strategy:
matrix:
node-version: [10.x, 12.x]
node-version: [14.x]
Copy link
Contributor

@jderochervlk jderochervlk Oct 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add 16 since it's the current LTS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jderochervlk jderochervlk jderochervlk left review comments

@JasoonS JasoonS JasoonS approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /