-
-
Notifications
You must be signed in to change notification settings - Fork 158
[1.x] Improve PHP 8.5+ support by avoiding deprecated setAccessible() calls
#325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WyriHaximus
commented
Aug 26, 2025
ac09dff to
68965d2
Compare
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@W0rma Thanks for the updates, changes LGTM! :shipit:
I've rebased your PR on current 1.x, all unrelated build errors have been fixed with #326 in the meantime, so time to move on finally! With these changes applied, tests against the current PHP 8.5 RC pass without errors (refs reactphp/dns#238 and clue/framework-x#282).
setAccessible() calls (追記ここまで)
@WyriHaximus
WyriHaximus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(https://www.php.net/manual/en/reflectionmethod.setaccessible.php and https://www.php.net/manual/en/reflectionproperty.setaccessible.php).
There're even plans to deprecate the method in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations