-
-
Notifications
You must be signed in to change notification settings - Fork 168
[1.x] Ensure connection close handler is cleaned up for each request #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SimonFrings
merged 1 commit into
reactphp:1.x
from
WyriHaximus-labs:1.x-ensure-connection-close-handler-cleanup
Mar 12, 2024
Merged
[1.x] Ensure connection close handler is cleaned up for each request #515
SimonFrings
merged 1 commit into
reactphp:1.x
from
WyriHaximus-labs:1.x-ensure-connection-close-handler-cleanup
Mar 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@WyriHaximus
WyriHaximus
force-pushed
the
1.x-ensure-connection-close-handler-cleanup
branch
2 times, most recently
from
February 19, 2024 16:57
4dfc331 to
07c80be
Compare
This changeset resolves a small memory leak that causes roughly 1KB per connection tops. Which isn't a big issue but will make memory fluctuate more. The changeset doesn't introduce any performance degradation. Resolves: reactphp#514 Builds on top of: reactphp#405, reactphp#467, and many others
@WyriHaximus
WyriHaximus
force-pushed
the
1.x-ensure-connection-close-handler-cleanup
branch
from
March 8, 2024 15:11
07c80be to
638c5dd
Compare
clue
clue
approved these changes
Mar 12, 2024
Member
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WyriHaximus Let's get this shipped! :shipit:
SimonFrings
SimonFrings
approved these changes
Mar 12, 2024
Member
@SimonFrings
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@WyriHaximus
WyriHaximus
deleted the
1.x-ensure-connection-close-handler-cleanup
branch
March 12, 2024 20:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset resolves a small memory leak that causes roughly 1KB per connection tops. Which isn't a big issue but will make memory fluctuate more. The changeset doesn't introduce any performance degradation.
Resolves: #514
Builds on top of: #405, #467, and many others