-
-
Notifications
You must be signed in to change notification settings - Fork 38
Test on PHP 7.3 and 7.4 #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on PHP 7.3 and 7.4 #78
Conversation
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures seem to be unrelated afaict?
The PHP 7.4 build reports plenty of warning because it's using an outdated PHPUnit version, so this should probably be updated as part of this PR 👍
WyriHaximus
commented
Feb 24, 2020
The test failures seem to be unrelated afaict?
They are, #79 will deal with those.
The PHP 7.4 build reports plenty of warning because it's using an outdated PHPUnit version, so this should probably be updated as part of this PR 👍
Working on bumping it to the latest version, takes some more changes then I hope for 😂
80ef142 to
2010a9b
Compare
And drop old PHP versions that don't support the new mock method
2010a9b to
f2a4dfd
Compare
No description provided.