-
-
Notifications
You must be signed in to change notification settings - Fork 60
[3.x] Improve PHP 8.4+ support by avoiding implicitly nullable types #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 22, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 22, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 27, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
clue
clue
reviewed
May 28, 2024
@WyriHaximus
WyriHaximus
force-pushed
the
3.x-nullable
branch
from
May 30, 2024 08:52
86d026e to
d237829
Compare
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
May 31, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
@WyriHaximus
WyriHaximus
force-pushed
the
3.x-nullable
branch
from
June 5, 2024 05:32
d237829 to
923fe70
Compare
clue
clue
reviewed
Jun 5, 2024
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs. Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch. Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260
@WyriHaximus
WyriHaximus
force-pushed
the
3.x-nullable
branch
from
June 5, 2024 08:44
923fe70 to
c15a0d6
Compare
clue
clue
approved these changes
Jun 5, 2024
Member
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WyriHaximus Thanks for the update, changes LGTM! :shipit:
SimonFrings
SimonFrings
approved these changes
Jun 5, 2024
Member
@SimonFrings
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, ship it 👍
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 5, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 13, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 14, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jun 14, 2024
This changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260.
I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs.
Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch.
Builds on top of #182, #222, reactphp/promise#260, reactphp/async#87 and reactphp/promise-timer#70