-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fix: Added react/jsv-dev-runtime to fakeRequire in compileMDX #8229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... the compileMDX function was only handing 'react/jsx-runtime' imports but in dev mode Next.js use 'react/jsx-dev-runtime' which exports jsxDEV. This was causing a 'jsxDEV is not a function' error when running yarn dev. This fix adds handling for 'react/jsx-dev-runtime' to the fakeRequire function, resolving the development mode compilation error.
Hi @prabrat!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Size changes
Details
📦 Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Before the fix the compileMDX function was only handing 'react/jsx-runtime' imports but in dev mode Next.js use 'react/jsx-dev-runtime' which exports jsxDEV. This was causing a 'jsxDEV is not a function' error when running yarn dev. This fix adds handling for 'react/jsx-dev-runtime' to the fakeRequire function, resolving the development mode compilation error.