This repository was archived by the owner on Jul 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Lesson 11 rewrite #245
Open
jnelssonsmith
wants to merge
6
commits into
reactjs:master
from
jnelssonsmith:lesson11-instructions-fix
Open
Lesson 11 rewrite #245
jnelssonsmith
wants to merge
6
commits into
reactjs:master
from
jnelssonsmith:lesson11-instructions-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Lesson 11 currently has been causing some issues, when all steps are completed it works, however following the tutorial step-by-step and testing the production version of the code does not work as intended/can be confusing for students. For instance if the student actually does try to use npm start when the lesson states, the screen will just be blank. You can navigate to files like package.json, but we shouldn't break the app to show this.
My understanding of the lesson is it wants to convey the following 2 points:
This rewrite still preserves these two aspects, but does them more directly than the current tutorial. The current tutorial takes the detour of making the user create it without the public directory, then add it and change the files again after realising that the user could access files they do not want.
In this new version, we explain the need for a public directory from the outset and make the code changes only once. I feel it is clearer this way and achieves the same effect in less time.