Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Lesson 11 rewrite #245

Open
jnelssonsmith wants to merge 6 commits into reactjs:master
base: master
Choose a base branch
Loading
from jnelssonsmith:lesson11-instructions-fix

Conversation

@jnelssonsmith
Copy link

@jnelssonsmith jnelssonsmith commented Oct 1, 2016
edited
Loading

Lesson 11 currently has been causing some issues, when all steps are completed it works, however following the tutorial step-by-step and testing the production version of the code does not work as intended/can be confusing for students. For instance if the student actually does try to use npm start when the lesson states, the screen will just be blank. You can navigate to files like package.json, but we shouldn't break the app to show this.

My understanding of the lesson is it wants to convey the following 2 points:

  1. Demonstrate the need for a public folder to serve out of when using a production version of your code
  2. Show how a sample simple production server could be created/used.

This rewrite still preserves these two aspects, but does them more directly than the current tutorial. The current tutorial takes the detour of making the user create it without the public directory, then add it and change the files again after realising that the user could access files they do not want.

In this new version, we explain the need for a public directory from the outset and make the code changes only once. I feel it is clearer this way and achieves the same effect in less time.

liuderchi reacted with thumbs up emoji
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /