Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Lesson 11 fix. #242

Open
jakeecolution wants to merge 1 commit into reactjs:master
base: master
Choose a base branch
Loading
from jakeecolution:productionish-server

Conversation

@jakeecolution
Copy link

@jakeecolution jakeecolution commented Sep 26, 2016

You output the bundle.js into the folder 'public' so you need to include to proper path in the index.html file now.

Copy link

jnelssonsmith commented Oct 1, 2016
edited
Loading

@bryanj4 the index.html file references the script through a relative path currently ./bundle.js meaning the bundle.js file in the same folder. You may have missed the part of the tutorial that said the index.html file should also be put into the public folder.

I think the underlying issue that we should fix is that the tutorial tells the student to test out the server before moving the index.html and index.css files into the public folder. Simply telling the students to do this before testing would eliminate this problem.

Copy link

cozmy commented Oct 7, 2016

At the moment, after we make the proposed changes of lesson 11, the ones until "Congratulations! You now have a production server...", as bundle.js is inside /public, express will return the content of index.html instead of it.

This issue can easily be avoided by just removing the "In the root directly, go open up webpack.config.js and add the publicPath '/' as per below:" section.

amacleay reacted with thumbs up emoji

Copy link

merriam commented Mar 21, 2017

This looks like a fix for the problems of #218, for which the better solution might be to just not set the public path until after the production server is running. I recommend closing the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /