Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed #35 add ability to show latest added notification on top. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxzxl wants to merge 1 commit into react-component:master
base: master
Choose a base branch
Loading
from lxzxl:master

Conversation

@lxzxl
Copy link

@lxzxl lxzxl commented Jan 16, 2018

No description provided.

Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e01fdd6 on lxzxl:master into 8af073b on react-component:master.

@yesmeck yesmeck assigned yesmeck and unassigned yesmeck Jan 22, 2018
Copy link
Member

yesmeck commented Jan 22, 2018

<td>function returning html node which will act as notification container</td>
</tr>
<tr>
<td>isLastTop</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a better name.

Copy link

@yutingzhao1991 yutingzhao1991 Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isReverse ?

Or use isAddOnTop, mean is add a new notification to top or bottom and it not a global change yet.

Copy link
Member

@yesmeck yesmeck Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newestOnTop

afc163 reacted with thumbs up emoji
Copy link
Member

afc163 commented May 8, 2020

conflicted

Copy link

@lxzxl Are you planning on fixing the conflicts?

Copy link

realhao commented May 18, 2022
edited
Loading

@lxzxl 这个新增功能是我们需要的,可以解决下冲突,完成 PR 吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesmeck yesmeck yesmeck left review comments

@yutingzhao1991 yutingzhao1991 yutingzhao1991 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /