-
-
Notifications
You must be signed in to change notification settings - Fork 412
Adding more custom dialogs: Error dialog #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dddomodossola
commented
Nov 30, 2017
Thank you a lot @int-0 ! You made a really good work. I haven't yet tested the code, but however appears to be good code. And you surprised me with the artwork :D
dddomodossola
commented
Dec 15, 2017
@int-0 I merged your code in branch "int-0_dialogs". I like the code you wrote and I will merge it in master branch. Just one question: why you haven't used GenericDialog as base class?
dddomodossola
commented
Jan 8, 2018
@int-0 You are making really good code, but I would ask you to make different pull reqs for different functionalities. This will allow a simpler review of the code. Thank you
Hi,
I'm using your amazing python library 👍
I write some custom dialogs... in this pull request only "Error" dialog is added but I'm going to create several more...
I'm glad to sending you this pull request I've been working on. You can use if you wish and it could be nice if you send any feedback.
Thank you and thank for your awesome work!