Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove dependency on distutils.version #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferdnyc wants to merge 1 commit into pythonprofilers:master
base: master
Choose a base branch
Loading
from ferdnyc:patch-1

Conversation

@ferdnyc
Copy link

@ferdnyc ferdnyc commented Feb 17, 2024
edited
Loading

distutils has been removed as of Python 3.12.

The replacement for distutils.version.LooseVersion, packaging.version.LegacyVersion, was similarly dropped from packaging as of version 22.

The only uses of LooseVersion() checks were to provide compatibility with IPython 0.10 - 0.12. Those versions didn't even support Python 3. Dropping compatibility with ancient IPython is the simplest fix.

Fixes #407

CharString reacted with thumbs up emoji
distutils has been removed as of Python 3.12.
The replacement for distutils.version.LooseVersion,
packaging.version.LegacyVersion, was similarly dropped from
packaging as of version 22.
The only uses of LooseVersion() checks were to provide compatibility
with IPython 0.10 - 0.12. Those versions didn't even support Python 3.
Dropping compatibility with ancient IPython is the simplest fix.
Copy link

Looks good, this closes #407

ferdnyc and grzanka reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing dependency on distutils

AltStyle によって変換されたページ (->オリジナル) /