-
Notifications
You must be signed in to change notification settings - Fork 24
Change conference name from multi-lingual field to CharField #4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Convert Conference.name from I18nCharField to models.CharField - Remove unused I18nCharField import from conference model - Create migration 0055 to handle database schema change - Update GraphQL Conference type to use regular field instead of localized resolver Fixes #4066 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marcoacierno
commented
Aug 4, 2025
@claude there are a few places where we do conference.name.localize(language_code). We don't ned the localize anymore, we can use name directly
Claude finished @marcoacierno's task —— View job
Finding and fixing conference.name.localize() calls ✅
- Read repository setup instructions (CLAUDE.md)
- Search for all instances of
conference.name.localize - Update each instance to use direct
nameaccess - Run linting/testing if available
- Commit and push changes
Completed! Found and updated 25 instances across 11 files:
backend/sponsors/tests/test_tasks.py✅backend/sponsors/tasks.py✅backend/submissions/tests/test_admin.py✅backend/submissions/admin.py✅backend/submissions/tasks.py✅backend/schedule/views.py✅backend/grants/tests/test_tasks.py✅backend/grants/tasks.py✅backend/schedule/tests/test_views.py✅backend/schedule/tests/test_tasks.py✅backend/schedule/video_upload.py✅backend/schedule/tasks.py✅
All instances of conference.name.localize(language_code) have been replaced with direct conference.name usage to match the CharField conversion. Changes committed and pushed to the PR branch.
- Replace conference.name.localize(language_code) with direct conference.name usage - Updated 25 instances across 11 files in backend codebase - Conference name is now a regular CharField, no longer needs localization Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
Codecov Report
✅ All modified and coverable lines are covered by tests.
main@f8a87d3). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@ ## main #4462 +/- ## ======================================= Coverage ? 94.53% ======================================= Files ? 352 Lines ? 10131 Branches ? 733 ======================================= Hits ? 9577 Misses ? 461 Partials ? 93
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
marcoacierno
commented
Aug 4, 2025
@claude We likely need to update the ConferenceFactory as well to not set name as a multi-lingual field anymore
Claude encountered an error —— View job
Updating ConferenceFactory to use CharField
- Read repository setup instructions (CLAUDE.md)
- Search for ConferenceFactory in the codebase
- Analyze current multi-lingual implementation
- Update factory to use simple CharField
- Run linting/testing if available
- Commit and push changes
Updated ConferenceFactory and test:
- Changed
name = LanguageFactory("name")toname = factory.Faker("word")inbackend/conferences/tests/factories.py:27 - Updated test in
backend/conferences/tests/test_models.pyto use simple string instead ofLazyI18nString - Removed unused
LazyI18nStringimport
Committing changes...
Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
Convert Conference.name from I18nCharField to models.CharField
Changes
Closes #4066
Generated with Claude Code