-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Use proper fixed format for parallel type checking IPC #20565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ilevkivskyi
merged 1 commit into
python:master
from
ilevkivskyi:fix-parallel-serial-fmt
Jan 12, 2026
Merged
Use proper fixed format for parallel type checking IPC #20565
ilevkivskyi
merged 1 commit into
python:master
from
ilevkivskyi:fix-parallel-serial-fmt
Jan 12, 2026
+254
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅
hauntsaninja
hauntsaninja
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small follow-up for #20280
As promised I am switching from an ad-hoc "binary JSON" format for IPC to a proper fixed format. The performance win is likely negligible, but it looks better and can be "statically typed". Note that since we don't have any backwards compatibility requirements nor need for messages to be decoded by a generic reader, I am using a simpler, more compact serialization format that incremental cache.