-
-
Notifications
You must be signed in to change notification settings - Fork 963
Update pull-request-lifecycle.rst with creating PR title and descriptions (#931) #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the "making a good PR" section of the page with tips on creating the title and description
All commit authors signed the Contributor License Agreement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this, where is the gh-XXXXX, and what is type?
An example title:
GH-132732: Use pure op machinery to optimize various instructions with
_POP_TOPand_POP_TWO
Updated the title formatting, and provided an example. Also removed trailing whitespaces.
pythonGH-931: Update pull-request-lifecycle.rst PR title and description section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the same issue I mentioned above (which was correct).
Uh oh!
There was an error while loading. Please reload this page.
Updated the "making a good PR" section of the page with tips on creating the title and description
#931📚 Documentation preview 📚: https://cpython-devguide--1626.org.readthedocs.build/