-
-
Notifications
You must be signed in to change notification settings - Fork 963
Move NEWS entries to pull-request-lifecycle #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 6860013.
StanFromIreland
commented
Feb 3, 2025
See also would be nice but it seems to make the section quoted.
@hugovk
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also would be nice but it seems to make the section quoted.
How do you mean?
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
StanFromIreland
commented
Feb 3, 2025
I must have done something weird before it works when I tried again!
@hugovk
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We improved a bit the content, but not by much, so it's fine to make it part of this change. I think we need a follow-up PR to improve the cases where a NEWS entry is necessary (see python/cpython#131177 (comment)). OTOH, you can revert the 3.X.rst mention and make it part of the follow-up PR.
Before merging, I'll check that the rst:role is correctly linked though.
picnixz
commented
Mar 13, 2025
Arf, it appears that we don't have the cross-referencing:
Well, let's introduce intersphinx in a future PR.
# Conflicts: # core-team/committing.rst
StanFromIreland
commented
Sep 13, 2025
Closed the originally linked issue as a duplicate of #674
Uh oh!
There was an error while loading. Please reload this page.
Fixes #674 (and duplicate #1242).
📚 Documentation preview 📚: https://cpython-devguide--1506.org.readthedocs.build/getting-started/pull-request-lifecycle/#what-s-new-and-news-entries