Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document that we have Docs Analytics using Plausible #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 4 commits into python:main
base: main
Choose a base branch
Loading
from StanFromIreland:patch-analytics

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 18, 2025
edited by hugovk
Loading

#1479

Created a new file for this as I was unable to find a good place for it in the existing documentation as it is most of tutorial form.

I think a separate file is good for expanding on this in the future, maybe more detail about the cookie and privacy concerns etc.?


📚 Documentation preview 📚: https://cpython-devguide--1496.org.readthedocs.build/

Copy link
Member

hugovk commented Jan 18, 2025

Thanks for the PR!

Hmm, I'm not sure if this needs a new page, for a single sentence? If we did expand it about cookies/privacy, I think that would mostly be to link to Plausible's own detailed descriptions on their own website.

@nedbat: related to the restructuring work, where do you think this would fit best? We might as well put it there already.


By the way, we don't need to prefix PRs with "gh-xxxx" in this repo.

@AA-Turner AA-Turner changed the title (削除) gh-1479: Document that we have Docs Analytics using Plausible (削除ここまで) (追記) Document that we have Docs Analytics using Plausible (追記ここまで) Jan 19, 2025
Copy link
Member

nedbat commented Jan 20, 2025

@hugovk Thanks for the heads-up, but this is a small enough change to accommodate later no matter what.

hugovk reacted with thumbs up emoji

Copy link
Member Author

@nedbat friendly ping :-)

Copy link
Member

Hugo's feedback is still outstanding:

Hmm, I'm not sure if this needs a new page, for a single sentence? If we did expand it about cookies/privacy, I think that would mostly be to link to Plausible's own detailed descriptions on their own website.

Please merge into a pre existing page.

Copy link
Member Author

@AA-Turner Ned didn't seem to mind. What page do you propose :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedbat nedbat Awaiting requested review from nedbat

1 more reviewer

@m-aciek m-aciek m-aciek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /