-
-
Notifications
You must be signed in to change notification settings - Fork 963
gh-1269: Added references for argument clinic directives #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@erlend-aasland
erlend-aasland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add this directly to the Argument Clinic docs; adding them as a separate page is going to be confusing.
Lincoln-developer
commented
Nov 4, 2024
I think we should add this directly to the Argument Clinic docs; adding them as a separate page is going to be confusing.
Okay, thanks for the review. Let me work on the requested changes.
development-tools/clinic.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend these to be definition lists? If not the indentation should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AA-Turner thanks for this insight, yeah! indeed to improve clarity its better not to make the content appear as a definition list.
Adjusted output destination list formatting as per feedback. Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
All commit authors signed the Contributor License Agreement.
Uh oh!
There was an error while loading. Please reload this page.
This pull request introduces references for argument clinic directives.
📚 Documentation preview 📚: https://cpython-devguide--1465.org.readthedocs.build/