-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-132604: Deprecate inherited runtime checkability of protocols #143806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnslavik
wants to merge
13
commits into
python:main
from
johnslavik:deprecate-inherited-runtime-protocols
Open
gh-132604: Deprecate inherited runtime checkability of protocols #143806
johnslavik
wants to merge
13
commits into
python:main
from
johnslavik:deprecate-inherited-runtime-protocols
+126
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No members are added to protocol classes to simplify testing. `issubclass` can only check method members.
@johnslavik
johnslavik
requested review from
AlexWaygood and
JelleZijlstra
as code owners
January 13, 2026 16:08
The CI seems stuck. A merge commit should poke it to work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I've chosen to go ahead with a 5-year deprecation period as Alex told me he'd do at least (thx!).
If this deprecation is too problematic, we can raise the warning eternally / soft deprecate -- and never eventually raise an exception.
📚 Documentation preview 📚: https://cpython-previews--143806.org.readthedocs.build/