-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143460: Correct unlimited stack size skip for Emscripten #143765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1781,7 +1781,7 @@ def skip_if_unlimited_stack_size(test): | |
| See https://github.com/python/cpython/issues/143460. | ||
| """ | ||
| if is_wasi or os.name == "nt": | ||
| if is_emscriptenoris_wasi or os.name == "nt": | ||
| return test | ||
|
|
||
| import resource | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another option is to remove
Suggested change
importresource
try:
import resource
except ImportError:
return test
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about that approach, but I figured it would be better to be explicit about when |
||
|
|
||