forked from psf/black
-
Notifications
You must be signed in to change notification settings - Fork 0
Add exponential function spacing option #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new --exponential-function-spacing flag that applies exponentially increasing blank lines between function definitions. The spacing follows the pattern 2^n where n is the function index (0-based): - 1st to 2nd function: 1 blank line (2^0) - 2nd to 3rd function: 2 blank lines (2^1) - 3rd to 4th function: 4 blank lines (2^2) - 4th to 5th function: 8 blank lines (2^3) This feature discourages developers from creating too many functions in a single file by making the visual separation increasingly dramatic. Changes: - Added exponential_function_spacing boolean field to Mode class - Updated Mode.__hash__ and get_cache_key to include new field - Added function_count_at_depth tracking to EmptyLineTracker - Modified empty line calculation logic to apply exponential spacing - Added --exponential-function-spacing CLI option
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
--exponential-function-spacingflag that applies exponentially increasing blank lines between function definitions to discourage developers from creating too many functions in a single file.Behavior
When enabled, the spacing follows the pattern 2^n where n is the function index (0-based):
Example
Before:
After (with --exponential-function-spacing):
Changes
exponential_function_spacingboolean field toModeclassMode.__hash__andget_cache_keyto include new fieldfunction_count_at_depthtracking toEmptyLineTracker--exponential-function-spacingCLI optionTest Plan